[PATCH 0/2] tps6598x: add device tree hooks and document

[PATCH 0/2] tps6598x: add device tree hooks and document

[Angus Ainslie]

Add device tree compatible string for tps6598x driver and create the dt binding doc for the driver

Angus Ainslie (2):
  usb: typec: tps6598x: add device tree hooks
  dt-bindings: usb: ti,tps6598x: add dt binding doc

 .../devicetree/bindings/usb/ti,tps6598x.yaml  | 75 +++++++++++++++++++
 drivers/usb/typec/tps6598x.c                  |  7 ++
 2 files changed, 82 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/usb/ti,tps6598x.yaml

-- 
2.25.1

[PATCH 1/2] usb: typec: tps6598x: add device tree hooks

[Angus Ainslie]

Add a compatible string for the devicetree.

Signed-off-by: Angus Ainslie <angus@akkea.ca>
---
 drivers/usb/typec/tps6598x.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/usb/typec/tps6598x.c b/drivers/usb/typec/tps6598x.c
index f661d8722ee0..2e71a35cc9d8 100644
--- a/drivers/usb/typec/tps6598x.c
+++ b/drivers/usb/typec/tps6598x.c
@@ -981,9 +981,16 @@ static const struct i2c_device_id tps6598x_id[] = {
 };
 MODULE_DEVICE_TABLE(i2c, tps6598x_id);
 
+static const struct of_device_id tps6598x_of_match[] = {
+	{ .compatible = "ti,tps6598x", },
+	{ },
+};
+MODULE_DEVICE_TABLE(of, tps6598x_of_match);
+
 static struct i2c_driver tps6598x_i2c_driver = {
 	.driver = {
 		.name = "tps6598x",
+		.of_match_table = of_match_ptr(tps6598x_of_match),
 	},
 	.probe_new = tps6598x_probe,
 	.remove = tps6598x_remove,
-- 
2.25.1

[PATCH 2/2] dt-bindings: usb: ti,tps6598x: add dt binding doc

[Angus Ainslie]

Document the tps6598x driver

Signed-off-by: Angus Ainslie <angus@akkea.ca>
---
 .../devicetree/bindings/usb/ti,tps6598x.yaml  | 75 +++++++++++++++++++
 1 file changed, 75 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/usb/ti,tps6598x.yaml

diff --git a/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml b/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
new file mode 100644
index 000000000000..925db38aaf84
--- /dev/null
+++ b/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
@@ -0,0 +1,75 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/usb/ti,tps6598x.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: TI tps6598x driver
+
+maintainers:
+  -
+
+properties:
+  $nodename:
+    pattern: '^usb-pd@.*'
+
+  compatible:
+    oneOf:
+      - enum:
+        - ti,tps6598x
+      - items:
+        - const: ti,tps6598x
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  connector:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+  - interrupts
+
+additionalProperties: false
+
+examples:
+  - |
+    typec_pd: usb-pd@3f {
+      compatible = "ti,tps6598x";
+      reg = <0x3f>;
+      pinctrl-names = "default";
+      pinctrl-0 = <&pinctrl_typec>, <&pinctrl_tcpc>;
+      interrupt-parent = <&gpio1>;
+      interrupts = <10 IRQ_TYPE_LEVEL_LOW>;
+
+      connector {
+        compatible = "usb-c-connector";
+        label = "USB-C";
+        data-role = "dual";
+
+        ports {
+          #address-cells = <1>;
+          #size-cells = <0>;
+
+          port@0 {
+            reg = <0>;
+
+            usb_con_hs: endpoint {
+              remote-endpoint = <&typec_hs>;
+            };
+          };
+
+          port@1 {
+            reg = <1>;
+
+            usb_con_ss: endpoint {
+              remote-endpoint = <&typec_ss>;
+            };
+          };
+        };
+      };
+    };
-- 
2.25.1

Re: [PATCH 2/2] dt-bindings: usb: ti,tps6598x: add dt binding doc

[Rob Herring]

On Wed,  6 May 2020 12:17:18 -0700, Angus Ainslie wrote:
> Document the tps6598x driver
> 
> Signed-off-by: Angus Ainslie <angus@akkea.ca>
> ---
>  .../devicetree/bindings/usb/ti,tps6598x.yaml  | 75 +++++++++++++++++++
>  1 file changed, 75 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
> 


My bot found errors running 'make dt_binding_check' on your patch:

/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml: maintainers:0: None is not of type 'string'
Documentation/devicetree/bindings/Makefile:12: recipe for target 'Documentation/devicetree/bindings/usb/ti,tps6598x.example.dts' failed
make[1]: *** [Documentation/devicetree/bindings/usb/ti,tps6598x.example.dts] Error 1
make[1]: *** Waiting for unfinished jobs....
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml: ignoring, error in schema: maintainers: 0
warning: no schema found in file: ./Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml: ignoring, error in schema: maintainers: 0
warning: no schema found in file: ./Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
Makefile:1300: recipe for target 'dt_binding_check' failed
make: *** [dt_binding_check] Error 2

See https://patchwork.ozlabs.org/patch/1284704

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure dt-schema is up to date:

pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade

Please check and re-submit.

Re: [PATCH 2/2] dt-bindings: usb: ti,tps6598x: add dt binding doc

[Angus Ainslie]

Hi Rob,

On 2020-05-11 08:26, Rob Herring wrote:
> On Wed,  6 May 2020 12:17:18 -0700, Angus Ainslie wrote:
>> Document the tps6598x driver
>> 
>> Signed-off-by: Angus Ainslie <angus@akkea.ca>
>> ---
>>  .../devicetree/bindings/usb/ti,tps6598x.yaml  | 75 
>> +++++++++++++++++++
>>  1 file changed, 75 insertions(+)
>>  create mode 100644 
>> Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
>> 
> 
> 
> My bot found errors running 'make dt_binding_check' on your patch:
> 
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml:
> maintainers:0: None is not of type 'string'
> Documentation/devicetree/bindings/Makefile:12: recipe for target
> 'Documentation/devicetree/bindings/usb/ti,tps6598x.example.dts' failed
> make[1]: ***
> [Documentation/devicetree/bindings/usb/ti,tps6598x.example.dts] Error
> 1
> make[1]: *** Waiting for unfinished jobs....
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml:
> ignoring, error in schema: maintainers: 0
> warning: no schema found in file:
> ./Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml:
> ignoring, error in schema: maintainers: 0
> warning: no schema found in file:
> ./Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
> Makefile:1300: recipe for target 'dt_binding_check' failed
> make: *** [dt_binding_check] Error 2
> 
> See https://patchwork.ozlabs.org/patch/1284704
> 
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure dt-schema is up to date:
> 
> pip3 install
> git+https://github.com/devicetree-org/dt-schema.git@master --upgrade
> 
> Please check and re-submit.

I think the consesus was to use this one instead.

https://lore.kernel.org/lkml/20200507122352.1773661-2-bryan.odonoghue@linaro.org/

Thanks
Angus