linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Tang Bin <tangbin@cmss.chinamobile.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Subject: Re: [PATCH] USB: host: ehci: Add error handling in ehci_mxc_drv_probe()
Date: Wed, 13 May 2020 15:01:17 +0200	[thread overview]
Message-ID: <20200513130117.GA1085323@kroah.com> (raw)
In-Reply-To: <9f88b0fd-28e9-2fa8-2deb-73652eb53fd4@cmss.chinamobile.com>

On Wed, May 13, 2020 at 08:55:59PM +0800, Tang Bin wrote:
> Hi gregkh:
> 
> On 2020/5/8 21:51, Alan Stern wrote:
> > On Fri, 8 May 2020, Tang Bin wrote:
> > 
> > > The function ehci_mxc_drv_probe() does not perform sufficient error
> > > checking after executing platform_get_irq(), thus fix it.
> > Aside from the "irq <= 0" issue, the Subject: line should say
> > "ehci-mxc", not "ehci".
> > 
> I know this patch need v2, whether just fix the subject?

0 is an invalid irq.


      reply	other threads:[~2020-05-13 13:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-08 11:44 [PATCH] USB: host: ehci: Add error handling in ehci_mxc_drv_probe() Tang Bin
2020-05-08 11:48 ` Greg KH
2020-05-08 13:55   ` [PATCH] USB: host: ehci: Add error handling inehci_mxc_drv_probe() Tang Bin
2020-05-08 14:31     ` Greg KH
2020-05-08 15:03       ` [PATCH] USB: host: ehci: Add error handlinginehci_mxc_drv_probe() Tang Bin
2020-05-08 20:27         ` Sergei Shtylyov
2020-05-09  1:13           ` Tang Bin
2020-05-08 20:30   ` [PATCH] USB: host: ehci: Add error handling in ehci_mxc_drv_probe() Sergei Shtylyov
2020-05-08 13:51 ` Alan Stern
2020-05-13 12:55   ` Tang Bin
2020-05-13 13:01     ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200513130117.GA1085323@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    --cc=tangbin@cmss.chinamobile.com \
    --cc=zhangshengju@cmss.chinamobile.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).