From: Greg KH <gregkh@linuxfoundation.org>
To: Oliver Neukum <oneukum@suse.com>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH] CDC-ACM: heed quirk also in error handling
Date: Wed, 27 May 2020 10:25:28 +0200 [thread overview]
Message-ID: <20200527082528.GA150074@kroah.com> (raw)
In-Reply-To: <20200526124420.22160-1-oneukum@suse.com>
On Tue, May 26, 2020 at 02:44:20PM +0200, Oliver Neukum wrote:
> If buffers are iterated over in the error case, the lower limits
> for quirky devices must be heeded.
>
> Signed-off-by: Oliver Neukum <oneukum@suse.com>
> Reported-by: Jean Rene Dawin <jdawin@math.uni-bielefeld.de>
> Fixes: a4e7279cd1d19 ("cdc-acm: introduce a cool down")
> Cc: stable <stable@vger.kernel.org>
> ---
> drivers/usb/class/cdc-acm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
> index 7678ae4afd53..be4543569822 100644
> --- a/drivers/usb/class/cdc-acm.c
> +++ b/drivers/usb/class/cdc-acm.c
> @@ -585,7 +585,7 @@ static void acm_softint(struct work_struct *work)
> }
>
> if (test_and_clear_bit(ACM_ERROR_DELAY, &acm->flags)) {
> - for (i = 0; i < ACM_NR; i++)
> + for (i = 0; i < acm->rx_buflimit; i++)
Trailing whitespace :(
I'll go fix it up by hand...
greg k-h
prev parent reply other threads:[~2020-05-27 8:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 12:44 [PATCH] CDC-ACM: heed quirk also in error handling Oliver Neukum
2020-05-27 8:25 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200527082528.GA150074@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).