From: Greg KH <gregkh@linuxfoundation.org>
To: Lokesh Chebrolu <lokeshch007@gmail.com>
Cc: hadess@hadess.net, stern@rowland.harvard.edu,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: usb: core: driver: fixed 80 line character length issue
Date: Sun, 31 May 2020 08:41:19 +0200 [thread overview]
Message-ID: <20200531064119.GD1082896@kroah.com> (raw)
In-Reply-To: <1590889806-13539-1-git-send-email-lokeshch007@gmail.com>
On Sun, May 31, 2020 at 07:20:06AM +0530, Lokesh Chebrolu wrote:
> From: lokeshch007 <lokeshch007@gmail.com>
This has to match the s-o-b line
>
> Fixed a coding style issue
What issue?
>
> Signed-off-by: Lokesh Chebrolu <lokeshch007@gmail.com>
> ---
> drivers/usb/core/driver.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/core/driver.c b/drivers/usb/core/driver.c
> index f81606c..83c3287 100644
> --- a/drivers/usb/core/driver.c
> +++ b/drivers/usb/core/driver.c
> @@ -1796,7 +1796,9 @@ int usb_autopm_get_interface_async(struct usb_interface *intf)
> EXPORT_SYMBOL_GPL(usb_autopm_get_interface_async);
>
> /**
> - * usb_autopm_get_interface_no_resume - increment a USB interface's PM-usage counter
> + * usb_autopm_get_interface_no_resume -
> + * increment a USB interface's PM-usage counter
> + *
Nope, the original is correct, sorry, kerneldoc wants this to be a long
single line.
When starting out in kernel development, please stick to
drivers/staging/ which has lots of places to clean up and patches like
this are welcomed much more so than other parts of the kernel.
thanks,
greg k-h
prev parent reply other threads:[~2020-05-31 6:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-31 1:50 [PATCH] drivers: usb: core: driver: fixed 80 line character length issue Lokesh Chebrolu
2020-05-31 6:41 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200531064119.GD1082896@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=hadess@hadess.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lokeshch007@gmail.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).