From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A983CC433DF for ; Fri, 19 Jun 2020 07:07:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 88C7920885 for ; Fri, 19 Jun 2020 07:07:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592550420; bh=7vLq9k86D0t1kk12AhQU4ptqPgt3dMPPfZGCY+OCNZg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=x9R04mGrdeQqmqIddbiN8BDADWO7tVtjIchH6+IUz+lTsjzxixsAlgag8VBB4eiz/ Ze5REe8zKGBx5z0pglKtnVuci3YqfwqXj9M46/v2TiyG0F/Vmi85SoRk9zLiBqUPlB 3iwOULRnOcQF41tQ3HBx5rxWI3MdUkX9n8+E7t2s= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730048AbgFSHG7 (ORCPT ); Fri, 19 Jun 2020 03:06:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:50990 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729009AbgFSHG7 (ORCPT ); Fri, 19 Jun 2020 03:06:59 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DB9A72080C; Fri, 19 Jun 2020 07:06:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592550419; bh=7vLq9k86D0t1kk12AhQU4ptqPgt3dMPPfZGCY+OCNZg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mpvA3E4Oy80U0x9Hw2zouoXvR3XFa4WSwuDDrwyKn8hZuBvv5DAaf7hIqUCLnQ7yI TebOXIe+4xPVyiHUXiCeg8KDtwpzDGmefdvIvII2Z/wX2+KNLyU320xL+Hiu0rK3FF qUdzNha/Hzk69pvC4AeLgaGqNmWuoEQ5my7pnoS8= Date: Fri, 19 Jun 2020 09:02:30 +0200 From: Greg KH To: Changming Liu Cc: linux-usb@vger.kernel.org, thomas@winischhofer.net, Changming Liu Subject: Re: [PATCH 1/4] USB: sisusbvga: change sisusb_write_mem_bulk Message-ID: <20200619070230.GA543568@kroah.com> References: <1592526534-1739-1-git-send-email-liu.changm@northeastern.edu> <1592526534-1739-2-git-send-email-liu.changm@northeastern.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1592526534-1739-2-git-send-email-liu.changm@northeastern.edu> Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Thu, Jun 18, 2020 at 08:28:51PM -0400, Changming Liu wrote: > isusb_write_mem_bulk calls sisusb_send_bulk_msg and > is called by sisusb_write. > Changed their parameters accordingly. Accordingly to what? The subject just says "change", it does not say what any of this was changed to here. > > Also change the local buf[4] of sisusb_write_mem_bulk > to u8. This fixed a potential undefined behavior. Shouldn't this be a separate patch so that I could be backported to older kernels as it would fix a potential issue? When you have "also" in a patch description, it almost always means you should split the patch up into multiple changes. > > Signed-off-by: Changming Liu This email address doesn't match the "From:" line :( thanks, greg k-h