From: Sasha Levin <sashal@kernel.org>
To: Qais Yousef <qais.yousef@arm.com>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Alan Stern <stern@rowland.harvard.edu>,
Tony Prisk <linux@prisktech.co.nz>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mathias Nyman <mathias.nyman@intel.com>,
Oliver Neukum <oneukum@suse.de>,
linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH AUTOSEL 5.7 229/388] usb/ohci-platform: Fix a warning when hibernating
Date: Sun, 21 Jun 2020 19:46:21 -0400 [thread overview]
Message-ID: <20200621234621.GC1931@sasha-vm> (raw)
In-Reply-To: <20200618095600.umb4gyegy2hszlep@e107158-lin.cambridge.arm.com>
On Thu, Jun 18, 2020 at 10:56:01AM +0100, Qais Yousef wrote:
>Hi Sasha/Alan
>
>On 06/17/20 21:05, Sasha Levin wrote:
>
>[...]
>
>> diff --git a/drivers/usb/host/ohci-platform.c b/drivers/usb/host/ohci-platform.c
>> index 7addfc2cbadc..4a8456f12a73 100644
>> --- a/drivers/usb/host/ohci-platform.c
>> +++ b/drivers/usb/host/ohci-platform.c
>> @@ -299,6 +299,11 @@ static int ohci_platform_resume(struct device *dev)
>> }
>>
>> ohci_resume(hcd, false);
>> +
>> + pm_runtime_disable(dev);
>> + pm_runtime_set_active(dev);
>> + pm_runtime_enable(dev);
>> +
>
>I am not sure what's the protocol here, but the series was fixing similar
>problems to this driver but I didn't myself directly observe a warning because
>of that.
>
>https://lore.kernel.org/lkml/20200518154931.6144-2-qais.yousef@arm.com/
>https://lore.kernel.org/lkml/20200518154931.6144-3-qais.yousef@arm.com/
>
>So just pointing it out in case they're worth backporting to stable too.
I'll grab them too, thanks!
--
Thanks,
Sasha
next prev parent reply other threads:[~2020-06-21 23:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200618010805.600873-1-sashal@kernel.org>
2020-06-18 1:02 ` [PATCH AUTOSEL 5.7 041/388] usblp: poison URBs upon disconnect Sasha Levin
2020-06-18 1:02 ` [PATCH AUTOSEL 5.7 042/388] usb: roles: Switch on role-switch uevent reporting Sasha Levin
2020-06-18 1:02 ` [PATCH AUTOSEL 5.7 069/388] usb: cdns3: Fix runtime PM imbalance on error Sasha Levin
2020-06-18 1:02 ` [PATCH AUTOSEL 5.7 071/388] usb: gadget: core: sync interrupt before unbind the udc Sasha Levin
2020-06-18 1:04 ` [PATCH AUTOSEL 5.7 167/388] usb: dwc3: gadget: Properly handle ClearFeature(halt) Sasha Levin
2020-06-18 1:04 ` [PATCH AUTOSEL 5.7 168/388] usb: dwc3: meson-g12a: check return of dwc3_meson_g12a_usb_init Sasha Levin
2020-06-18 1:04 ` [PATCH AUTOSEL 5.7 169/388] usb: dwc3: gadget: Properly handle failed kick_transfer Sasha Levin
2020-06-18 1:04 ` [PATCH AUTOSEL 5.7 200/388] USB: ohci-sm501: fix error return code in ohci_hcd_sm501_drv_probe() Sasha Levin
2020-06-18 1:05 ` [PATCH AUTOSEL 5.7 229/388] usb/ohci-platform: Fix a warning when hibernating Sasha Levin
2020-06-18 9:56 ` Qais Yousef
2020-06-21 23:46 ` Sasha Levin [this message]
2020-06-18 1:05 ` [PATCH AUTOSEL 5.7 233/388] USB: host: ehci-mxc: Add error handling in ehci_mxc_drv_probe() Sasha Levin
2020-06-18 1:06 ` [PATCH AUTOSEL 5.7 264/388] usb: dwc2: gadget: move gadget resume after the core is in L0 state Sasha Levin
2020-06-18 1:06 ` [PATCH AUTOSEL 5.7 265/388] USB: gadget: udc: s3c2410_udc: Remove pointless NULL check in s3c2410_udc_nuke Sasha Levin
2020-06-18 1:06 ` [PATCH AUTOSEL 5.7 266/388] usb: gadget: lpc32xx_udc: don't dereference ep pointer before null check Sasha Levin
2020-06-18 1:06 ` [PATCH AUTOSEL 5.7 267/388] usb: gadget: fix potential double-free in m66592_probe Sasha Levin
2020-06-18 1:06 ` [PATCH AUTOSEL 5.7 268/388] usb: gadget: Fix issue with config_ep_by_speed function Sasha Levin
2020-06-18 1:06 ` [PATCH AUTOSEL 5.7 305/388] usb: dwc3: meson-g12a: fix error path when fetching the reset line fails Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200621234621.GC1931@sasha-vm \
--to=sashal@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@prisktech.co.nz \
--cc=mathias.nyman@intel.com \
--cc=oneukum@suse.de \
--cc=qais.yousef@arm.com \
--cc=stable@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox