From: Johan Hovold <johan@kernel.org>
To: Rob Gill <rrobgill@protonmail.com>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH v3] driver/usb MODULE_DESCRIPTION entries to usb modules
Date: Mon, 22 Jun 2020 11:22:06 +0200 [thread overview]
Message-ID: <20200622092206.GC3334@localhost> (raw)
In-Reply-To: <20200619133141.31890-1-rrobgill@protonmail.com>
On Fri, Jun 19, 2020 at 01:31:48PM +0000, Rob Gill wrote:
> The user tool modinfo is used to get information on kernel modules, including a
> description where it is available.
>
> This patch adds a brief MODULE_DESCRIPTION to the following modules in driver/usb.
>
> isight_firmware
> mxuport
> u_ether
> uas
We have literally thousands of modules without a module description, so
why this arbitrary and incomplete set?
If the driver author did not care to add a description I don't think we
should go adding mostly pointless descriptions to all those drivers now.
> Signed-off-by: Rob Gill <rrobgill@protonmail.com>
>
> ---
> drivers/usb/gadget/function/u_ether.c | 1 +
> drivers/usb/misc/isight_firmware.c | 1 +
> drivers/usb/serial/mxuport.c | 1 +
> drivers/usb/storage/uas.c | 1 +
> 4 files changed, 4 insertions(+)
Johan
next prev parent reply other threads:[~2020-06-22 9:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-19 13:31 [PATCH v3] driver/usb MODULE_DESCRIPTION entries to usb modules Rob Gill
2020-06-22 9:22 ` Johan Hovold [this message]
2020-06-24 9:42 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200622092206.GC3334@localhost \
--to=johan@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rrobgill@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).