linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Wesley Cheng <wcheng@codeaurora.org>
Cc: jackp@codeaurora.org, gregkh@linuxfoundation.org,
	rdunlap@infradead.org, linux-kernel@vger.kernel.org,
	linux-usb@vger.kernel.org, lgirdwood@gmail.com,
	linux-arm-msm@vger.kernel.org, broonie@kernel.org,
	robh+dt@kernel.org, devicetree@vger.kernel.org,
	agross@kernel.org, mark.rutland@arm.com,
	heikki.krogerus@linux.intel.com, bjorn.andersson@linaro.org
Subject: Re: [PATCH v4 2/6] dt-bindings: usb: Add Qualcomm PMIC type C controller dt-binding
Date: Mon, 29 Jun 2020 16:07:37 -0600	[thread overview]
Message-ID: <20200629220737.GA3027039@bogus> (raw)
In-Reply-To: <20200626185516.18018-3-wcheng@codeaurora.org>

On Fri, 26 Jun 2020 11:55:12 -0700, Wesley Cheng wrote:
> Introduce the dt-binding for enabling USB type C orientation and role
> detection using the PM8150B.  The driver will be responsible for receiving
> the interrupt at a state change on the CC lines, reading the orientation/role,
> and communicating this information to the remote clients, which can include
> a role switch node and a type C switch.
> 
> Signed-off-by: Wesley Cheng <wcheng@codeaurora.org>
> ---
>  .../bindings/usb/qcom,pmic-typec.yaml         | 126 ++++++++++++++++++
>  1 file changed, 126 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml
> 


My bot found errors running 'make dt_binding_check' on your patch:

Documentation/devicetree/bindings/usb/qcom,pmic-typec.example.dts:40.54-42.31: Warning (unit_address_vs_reg): /example-0/pm8150b/typec@1500/connector/ports/port@1/endpoint@0: node has a unit name, but no reg or ranges property
Documentation/devicetree/bindings/usb/qcom,pmic-typec.example.dts:43.51-45.31: Warning (unit_address_vs_reg): /example-0/pm8150b/typec@1500/connector/ports/port@1/endpoint@1: node has a unit name, but no reg or ranges property


See https://patchwork.ozlabs.org/patch/1317984

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure dt-schema is up to date:

pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade

Please check and re-submit.


  reply	other threads:[~2020-06-29 22:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-26 18:55 [PATCH v4 0/6] Introduce PMIC based USB type C detection Wesley Cheng
2020-06-26 18:55 ` [PATCH v4 1/6] usb: typec: Add QCOM PMIC typec detection driver Wesley Cheng
2020-06-29  7:22   ` Heikki Krogerus
2020-06-26 18:55 ` [PATCH v4 2/6] dt-bindings: usb: Add Qualcomm PMIC type C controller dt-binding Wesley Cheng
2020-06-29 22:07   ` Rob Herring [this message]
2020-06-26 18:55 ` [PATCH v4 3/6] arm64: boot: dts: qcom: pm8150b: Add node for USB type C block Wesley Cheng
2020-06-26 18:55 ` [PATCH v4 4/6] regulator: Add support for QCOM PMIC VBUS booster Wesley Cheng
2020-06-26 18:55 ` [PATCH v4 5/6] dt-bindings: regulator: Add dt-binding for QCOM PMIC VBUS output regulator Wesley Cheng
2020-06-26 18:55 ` [PATCH v4 6/6] arm64: boot: dts: qcom: pm8150b: Add DTS node for PMIC VBUS booster Wesley Cheng
2020-07-01 22:23 ` [PATCH v4 0/6] Introduce PMIC based USB type C detection Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200629220737.GA3027039@bogus \
    --to=robh@kernel.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=jackp@codeaurora.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=rdunlap@infradead.org \
    --cc=robh+dt@kernel.org \
    --cc=wcheng@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).