From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1D97C433E1 for ; Wed, 1 Jul 2020 16:54:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9C4DF207C4 for ; Wed, 1 Jul 2020 16:54:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593622457; bh=w0LJf58ZHrePxUOhoSEHwkGU11TOzfaBtfencec6dOg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=jjpWUYl1UOtl12XqQ+ebQfb2b55V57Da8KkHvHnJHBlIkcDF4mBHg/poB6W11VDg/ D8D5q1TODVrpONikNbPAfspnPNO7EWdq79ZLgdrIeqhD1kwuOF6X6xAqTSvtagdK+i QqSedK5LTVaXiorzdccoBF/e5UyYUK1sxVqwG55Y= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732805AbgGAQyQ (ORCPT ); Wed, 1 Jul 2020 12:54:16 -0400 Received: from mail-lj1-f194.google.com ([209.85.208.194]:35053 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732544AbgGAQyN (ORCPT ); Wed, 1 Jul 2020 12:54:13 -0400 Received: by mail-lj1-f194.google.com with SMTP id f8so15720195ljc.2 for ; Wed, 01 Jul 2020 09:54:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XqN5BMTTSq0kRme7uXuwIzqY4FXUwpkC+v2C+TXGWC8=; b=psvx4DkmFIjF94ZCeIbssc8X/FQa02u8MWtgprorfXGUDWXSwKMxumtf2JI0kVYAB9 qfKOZclPOsw5TGkJTA09N/vKxOk/f7crjTY4PhqzlwP6l1b9Pay1jNEDforLM4lIJxBV UwO7fgbkK7mXFSipl0ZqVdxQPyMrZb4scBYI2uTRL/CvmEBwaaXbxUoJccBhcGh8yIMJ 2p3QReqxNk8UpSx48WR7+tjvRvCsI6XbijqzF8tVFpE95SVAnYd8wraJ3aIfiXOTjOcU O9lShgisW8nSBeBy756hu227Ed7Uz8Si0JvEb/UA9YIkBbbe+tjxZHCE+OKcMCB0CJm/ dgZA== X-Gm-Message-State: AOAM533Yyym/BUT3D2WAKlchrGkwou+Cvr7Y/ydfAVQ/vPQkL2bv7i60 rb2Ip9vgF/2iAcn8e+x4c8FYdE9XA04= X-Google-Smtp-Source: ABdhPJxCVFwjbu6xEtiLyxmIbpoeE1K/b5YUK75ublcWu2kLG8Yj0LZJS2t3YJGioXg16NkTMt0xNA== X-Received: by 2002:a2e:161a:: with SMTP id w26mr13906073ljd.216.1593622451281; Wed, 01 Jul 2020 09:54:11 -0700 (PDT) Received: from xi.terra (c-beaee455.07-184-6d6c6d4.bbcust.telenor.se. [85.228.174.190]) by smtp.gmail.com with ESMTPSA id 81sm2253295lfj.24.2020.07.01.09.54.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2020 09:54:10 -0700 (PDT) Received: from johan by xi.terra with local (Exim 4.93.0.4) (envelope-from ) id 1jqfzq-000425-Ca; Wed, 01 Jul 2020 18:54:06 +0200 From: Johan Hovold To: Johan Hovold Cc: linux-usb@vger.kernel.org Subject: [PATCH 1/5] USB: serial: garmin_gps: don't compile unused packet definitions Date: Wed, 1 Jul 2020 18:53:38 +0200 Message-Id: <20200701165342.15448-2-johan@kernel.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200701165342.15448-1-johan@kernel.org> References: <20200701165342.15448-1-johan@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Don't compile the four unused packet definitions but keep them around for documentation purposes. This avoids the corresponding W=1 (-Wunused-const-variable) warnings. Signed-off-by: Johan Hovold --- drivers/usb/serial/garmin_gps.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/usb/serial/garmin_gps.c b/drivers/usb/serial/garmin_gps.c index d63072fee099..c02c19bb1183 100644 --- a/drivers/usb/serial/garmin_gps.c +++ b/drivers/usb/serial/garmin_gps.c @@ -179,19 +179,22 @@ static unsigned char const GARMIN_START_SESSION_REPLY[] = { 0, 0, 0, 0, 6, 0, 0, 0, 4, 0, 0, 0 }; static unsigned char const GARMIN_BULK_IN_AVAIL_REPLY[] = { 0, 0, 0, 0, 2, 0, 0, 0, 0, 0, 0, 0 }; +static unsigned char const GARMIN_STOP_TRANSFER_REQ[] + = { 20, 0, 0, 0, 10, 0, 0, 0, 2, 0, 0, 0, 0, 0 }; +static unsigned char const GARMIN_STOP_TRANSFER_REQ_V2[] + = { 20, 0, 0, 0, 10, 0, 0, 0, 1, 0, 0, 0, 0 }; + +/* packets currently unused, left as documentation */ +#if 0 static unsigned char const GARMIN_APP_LAYER_REPLY[] = { 0x14, 0, 0, 0 }; static unsigned char const GARMIN_START_PVT_REQ[] = { 20, 0, 0, 0, 10, 0, 0, 0, 2, 0, 0, 0, 49, 0 }; static unsigned char const GARMIN_STOP_PVT_REQ[] = { 20, 0, 0, 0, 10, 0, 0, 0, 2, 0, 0, 0, 50, 0 }; -static unsigned char const GARMIN_STOP_TRANSFER_REQ[] - = { 20, 0, 0, 0, 10, 0, 0, 0, 2, 0, 0, 0, 0, 0 }; -static unsigned char const GARMIN_STOP_TRANSFER_REQ_V2[] - = { 20, 0, 0, 0, 10, 0, 0, 0, 1, 0, 0, 0, 0 }; static unsigned char const PRIVATE_REQ[] = { 0x4B, 0x6E, 0x10, 0x01, 0xFF, 0, 0, 0, 0xFF, 0, 0, 0 }; - +#endif static const struct usb_device_id id_table[] = { -- 2.26.2