From: Johan Hovold <johan@kernel.org>
To: Johan Hovold <johan@kernel.org>
Cc: linux-usb@vger.kernel.org
Subject: [PATCH 4/5] USB: serial: kobil_sct: log failure to update line settings
Date: Wed, 1 Jul 2020 18:53:41 +0200 [thread overview]
Message-ID: <20200701165342.15448-5-johan@kernel.org> (raw)
In-Reply-To: <20200701165342.15448-1-johan@kernel.org>
Log failure to update the line settings in set_termios().
This also avoids a W=1 (-Wunused-but-set-variable) warning.
Signed-off-by: Johan Hovold <johan@kernel.org>
---
drivers/usb/serial/kobil_sct.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/usb/serial/kobil_sct.c b/drivers/usb/serial/kobil_sct.c
index e9882ba20933..79ce0219fdde 100644
--- a/drivers/usb/serial/kobil_sct.c
+++ b/drivers/usb/serial/kobil_sct.c
@@ -526,6 +526,10 @@ static void kobil_set_termios(struct tty_struct *tty,
0,
KOBIL_TIMEOUT
);
+ if (result) {
+ dev_err(&port->dev, "failed to update line settings: %d\n",
+ result);
+ }
}
static int kobil_ioctl(struct tty_struct *tty,
--
2.26.2
next prev parent reply other threads:[~2020-07-01 16:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 16:53 [PATCH 0/5] USB: serial: W=1 related cleanups Johan Hovold
2020-07-01 16:53 ` [PATCH 1/5] USB: serial: garmin_gps: don't compile unused packet definitions Johan Hovold
2020-07-01 16:53 ` [PATCH 2/5] USB: serial: iuu_phoenix: drop unused URB submission results Johan Hovold
2020-07-01 16:53 ` [PATCH 3/5] USB: serial: keyspan_pda: drop unused firmware reset status Johan Hovold
2020-07-01 16:53 ` Johan Hovold [this message]
2020-07-01 16:53 ` [PATCH 5/5] USB: serial: quatech2: drop two stub functions Johan Hovold
2020-07-01 17:23 ` [PATCH 0/5] USB: serial: W=1 related cleanups Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200701165342.15448-5-johan@kernel.org \
--to=johan@kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).