From: Johan Hovold <johan@kernel.org>
To: linux-usb@vger.kernel.org, Michael Hanselmann <public@hansmi.ch>
Cc: Johan Hovold <johan@kernel.org>
Subject: [PATCH] USB: serial: ch341: fix simulated-break comment
Date: Tue, 7 Jul 2020 08:19:57 +0200 [thread overview]
Message-ID: <20200707061957.17425-1-johan@kernel.org> (raw)
On devices which do not support break signalling a break condition is
simulated by sending a NUL byte at the lowest possible speed. The break
condition will be 9 bit periods long (start bit and eight data bits),
but the transmission itself also includes the stop bit.
Signed-off-by: Johan Hovold <johan@kernel.org>
---
Hi Michael,
I reread the break-end comment and found it a bit confusing still. The
below seems more correct to me. I'm assuming you did not intend to add
an additional bit period as margin?
Johan
drivers/usb/serial/ch341.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/serial/ch341.c b/drivers/usb/serial/ch341.c
index 011d7953f087..27a2a62777c9 100644
--- a/drivers/usb/serial/ch341.c
+++ b/drivers/usb/serial/ch341.c
@@ -604,9 +604,8 @@ static void ch341_simulate_break(struct tty_struct *tty, int break_state)
}
/*
- * Compute expected transmission duration and add a single bit
- * of safety margin (the actual NUL byte transmission is 8 bits
- * plus one stop bit).
+ * Compute expected transmission duration (including stop
+ * bit).
*/
priv->break_end = jiffies + (10 * HZ / CH341_MIN_BPS);
--
2.26.2
next reply other threads:[~2020-07-07 6:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 6:19 Johan Hovold [this message]
2020-07-07 14:53 ` [PATCH] USB: serial: ch341: fix simulated-break comment Michael Hanselmann
2020-07-07 15:35 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200707061957.17425-1-johan@kernel.org \
--to=johan@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=public@hansmi.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).