From: Peter Chen <peter.chen@nxp.com>
To: Pawel Laszczak <pawell@cadence.com>
Cc: "balbi@kernel.org" <balbi@kernel.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"rogerq@ti.com" <rogerq@ti.com>,
"dan.carpenter@oracle.com" <dan.carpenter@oracle.com>,
"heikki.krogerus@linux.intel.com"
<heikki.krogerus@linux.intel.com>,
"colin.king@canonical.com" <colin.king@canonical.com>,
"jpawar@cadence.com" <jpawar@cadence.com>,
"ben.dooks@codethink.co.uk" <ben.dooks@codethink.co.uk>,
"kurahul@cadence.com" <kurahul@cadence.com>,
"sparmar@cadence.com" <sparmar@cadence.com>
Subject: Re: [PATCH 3/9] usb: cnds3: Improvement: deleted !=
Date: Tue, 7 Jul 2020 06:24:37 +0000 [thread overview]
Message-ID: <20200707062447.GD16073@b29397-desktop> (raw)
In-Reply-To: <20200701062004.29908-4-pawell@cadence.com>
On 20-07-01 08:19:58, Pawel Laszczak wrote:
> Patch deletes unnecessary != from condition statement ini cdns3_drd_init
> function.
Change the title.
%s/ini/in
Peter
>
> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
> ---
> drivers/usb/cdns3/drd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/cdns3/drd.c b/drivers/usb/cdns3/drd.c
> index 4939a568d8a2..6d2da504ad49 100644
> --- a/drivers/usb/cdns3/drd.c
> +++ b/drivers/usb/cdns3/drd.c
> @@ -365,7 +365,7 @@ int cdns3_drd_init(struct cdns3 *cdns)
> }
>
> state = readl(&cdns->otg_regs->sts);
> - if (OTGSTS_OTG_NRDY(state) != 0) {
> + if (OTGSTS_OTG_NRDY(state)) {
> dev_err(cdns->dev, "Cadence USB3 OTG device not ready\n");
> return -ENODEV;
> }
> --
> 2.17.1
>
--
Thanks,
Peter Chen
next prev parent reply other threads:[~2020-07-07 6:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 6:19 [PATCH 0/9] usb: cdns3: Improvements for cdns3 DRD code Pawel Laszczak
2020-07-01 6:19 ` [PATCH 1/9] usb: cdns3: Improvement: removed cdns3_get_current_role_driver function Pawel Laszczak
2020-07-07 6:20 ` Peter Chen
2020-07-01 6:19 ` [PATCH 2/9] usb: cdns3: Improvement: removed not needed variables initialization Pawel Laszczak
2020-07-07 6:23 ` Peter Chen
2020-07-07 10:16 ` Dan Carpenter
2020-07-08 6:53 ` Peter Chen
2020-07-08 14:18 ` Pawel Laszczak
2020-07-01 6:19 ` [PATCH 3/9] usb: cnds3: Improvement: deleted != Pawel Laszczak
2020-07-07 6:24 ` Peter Chen [this message]
2020-07-01 6:19 ` [PATCH 4/9] usb: cdns3: Improvement: return IRQ_NONE explicitly Pawel Laszczak
2020-07-01 6:20 ` [PATCH 5/9] usb: cdns3: Improvement: changed return type from int to bool Pawel Laszczak
2020-07-01 6:20 ` [PATCH 6/9] usb: cdns3: Added CDNS3_ID_PERIPHERAL and CDNS3_ID_HOST Pawel Laszczak
2020-07-07 6:30 ` Peter Chen
2020-07-07 10:21 ` Dan Carpenter
2020-07-01 6:20 ` [PATCH 7/9] usb: cdns3: Improvement: removed 'goto not_otg' Pawel Laszczak
2020-07-07 6:33 ` Peter Chen
2020-07-01 6:20 ` [PATCH 8/9] usb: cdns3: Improvement: removed overwriting some error code Pawel Laszczak
2020-07-07 6:38 ` Peter Chen
2020-07-01 6:20 ` [PATCH 9/9] usb: cdns3: Impovement: simplify *switch_gadet and *switch_host Pawel Laszczak
2020-07-07 6:41 ` Peter Chen
2020-07-07 6:18 ` [PATCH 0/9] usb: cdns3: Improvements for cdns3 DRD code Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200707062447.GD16073@b29397-desktop \
--to=peter.chen@nxp.com \
--cc=balbi@kernel.org \
--cc=ben.dooks@codethink.co.uk \
--cc=colin.king@canonical.com \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jpawar@cadence.com \
--cc=kurahul@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pawell@cadence.com \
--cc=rogerq@ti.com \
--cc=sparmar@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).