From: Greg KH <greg@kroah.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Colton Lewis <colton.w.lewis@protonmail.com>,
gregkh@linuxfoundation.og, balbi@kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH 1/2] usb: correct kernel-doc inconsistency
Date: Tue, 7 Jul 2020 20:02:38 +0200 [thread overview]
Message-ID: <20200707180238.GA252415@kroah.com> (raw)
In-Reply-To: <6c25acb6-f702-0ce0-508d-d55080fe469f@infradead.org>
On Mon, Jul 06, 2020 at 10:14:24PM -0700, Randy Dunlap wrote:
> On 7/6/20 9:52 PM, Colton Lewis wrote:
> > Silence documentation build warning by correcting kernel-doc comment
> > for sub_validate_langid function.
> >
> > ./drivers/usb/gadget/usbstring.c:77: warning: Function parameter or member 'langid' not described in 'usb_validate_langid'
> > ./drivers/usb/gadget/usbstring.c:77: warning: Excess function parameter 'lang' description in 'usb_validate_langid'
> >
> > Signed-off-by: Colton Lewis <colton.w.lewis@protonmail.com>
> > ---
> > drivers/usb/gadget/usbstring.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/usb/gadget/usbstring.c b/drivers/usb/gadget/usbstring.c
> > index 58a4d3325090..119505fac777 100644
> > --- a/drivers/usb/gadget/usbstring.c
> > +++ b/drivers/usb/gadget/usbstring.c
> > @@ -68,7 +68,7 @@ EXPORT_SYMBOL_GPL(usb_gadget_get_string);
> >
> > /**
> > * usb_validate_langid - validate usb language identifiers
> > - * @lang: usb language identifier
> > + * @langid: usb language identifier
> > *
> > * Returns true for valid language identifier, otherwise false.
> > */
> >
>
> Hi,
> I sent a patch for this on June 28, but it has not yet been merged anywhere
> AFAIK.
Have a message-id? I don't see it in my queue.
thanks,
greg k-h
next prev parent reply other threads:[~2020-07-07 18:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 4:52 [PATCH 1/2] usb: correct kernel-doc inconsistency Colton Lewis
2020-07-07 4:52 ` [PATCH 2/2] " Colton Lewis
2020-07-07 5:17 ` Randy Dunlap
2020-07-07 18:02 ` Greg KH
2020-07-07 18:06 ` Randy Dunlap
2020-07-07 5:14 ` [PATCH 1/2] " Randy Dunlap
2020-07-07 18:02 ` Greg KH [this message]
2020-07-07 18:09 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200707180238.GA252415@kroah.com \
--to=greg@kroah.com \
--cc=balbi@kernel.org \
--cc=colton.w.lewis@protonmail.com \
--cc=gregkh@linuxfoundation.og \
--cc=linux-usb@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox