From: Greg KH <gregkh@linuxfoundation.org>
To: "Alexander A. Klimov" <grandmaster@al2klimov.de>
Cc: stern@rowland.harvard.edu, linux-usb@vger.kernel.org,
usb-storage@lists.one-eyed-alien.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Replace HTTP links with HTTPS ones: USB MASS STORAGE DRIVER
Date: Wed, 8 Jul 2020 12:39:28 +0200 [thread overview]
Message-ID: <20200708103928.GC585606@kroah.com> (raw)
In-Reply-To: <20200708095500.13694-1-grandmaster@al2klimov.de>
On Wed, Jul 08, 2020 at 11:55:00AM +0200, Alexander A. Klimov wrote:
> Rationale:
> Reduces attack surface on kernel devs opening the links for MITM
> as HTTPS traffic is much harder to manipulate.
>
> Deterministic algorithm:
> For each file:
> If not .svg:
> For each line:
> If doesn't contain `\bxmlns\b`:
> For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
> If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`:
> If both the HTTP and HTTPS versions
> return 200 OK and serve the same content:
> Replace HTTP with HTTPS.
>
> Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov.de>
Your subject lines are very odd compared to all patches for this
subsystem, as well as all other kernel subsystems. Any reason you are
doing it this way and not the normal and standard method of:
USB: storage: replace http links with https
That would look more uniform as well as not shout at anyone.
thanks,
greg k-h
next prev parent reply other threads:[~2020-07-08 10:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 9:55 [PATCH] Replace HTTP links with HTTPS ones: USB MASS STORAGE DRIVER Alexander A. Klimov
2020-07-08 10:39 ` Greg KH [this message]
2020-07-08 18:41 ` Alexander A. Klimov
2020-07-09 6:14 ` Greg KH
2020-07-10 10:36 ` Stafford Horne
2020-07-10 19:36 ` Alexander A. Klimov
2020-07-10 20:55 ` Stafford Horne
2020-07-10 21:18 ` Alexander A. Klimov
2020-07-10 21:35 ` Jonathan Corbet
2020-07-11 5:29 ` Alexander A. Klimov
2020-07-08 18:49 ` [PATCH] USB: storage: replace HTTP links with HTTPS ones Alexander A. Klimov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200708103928.GC585606@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=grandmaster@al2klimov.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).