From: "Gustavo A. R. Silva" <gustavoars@kernel.org>
To: Shuah Khan <skhan@linuxfoundation.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Valentina Manea <valentina.manea.m@gmail.com>,
Shuah Khan <shuah@kernel.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usbip: Use fallthrough pseudo-keyword
Date: Wed, 8 Jul 2020 13:11:44 -0500 [thread overview]
Message-ID: <20200708181144.GB11533@embeddedor> (raw)
In-Reply-To: <977e88c2-58cb-9507-c889-854e574a8f31@linuxfoundation.org>
On Tue, Jul 07, 2020 at 02:06:26PM -0600, Shuah Khan wrote:
> On 7/7/20 1:52 PM, Gustavo A. R. Silva wrote:
> > Replace the existing /* fall through */ comments and its variants with
> > the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
> > fall-through markings when it is the case.
> >
> > [1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
> >
>
> Is fallthrough syntax supported on our min gcc version?
>
The __attribute__((__fallthrough__)) has been supported since GCC 7.1
and it should be no problem for early versions because fallthrough is
a macro that also expands to: do {} while (0) /* fallthrough */
> Does checkpatch or coccicheck catch these cases?
>
checkpatch does:
https://git.kernel.org/linus/f36d3eb89a43047d3eba222a8132585da25cebfd
> The patch looks good.
>
> Acked-by: Shuah Khan <skhan@linuxfoundation.org>
>
Thanks
--
Gustavo
next prev parent reply other threads:[~2020-07-08 18:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 19:52 [PATCH] usbip: Use fallthrough pseudo-keyword Gustavo A. R. Silva
2020-07-07 20:06 ` Shuah Khan
2020-07-08 1:56 ` Joe Perches
2020-07-08 10:16 ` Julia Lawall
2020-07-08 14:42 ` Shuah Khan
2020-07-08 14:35 ` Shuah Khan
2020-07-08 15:39 ` Joe Perches
2020-07-08 16:39 ` Shuah Khan
2020-07-08 18:11 ` Gustavo A. R. Silva [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-02-15 9:26 [PATCH] USBIP: " Pairman Guo
2024-02-15 10:14 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200708181144.GB11533@embeddedor \
--to=gustavoars@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=valentina.manea.m@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).