From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C711C433E1 for ; Mon, 13 Jul 2020 15:51:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4F60420663 for ; Mon, 13 Jul 2020 15:51:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594655492; bh=UeqdQ5Ai6a37CRGQJQSRCJSFMdVA0qgwG68F8CKF9Ds=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=pnoj1L6JGnVbARWJXZRYKNYM8EV0kk3QD/vz0oG1sUDS9sid+OB7uWSXjGXan9cC0 vYCRMCPCQTAefIUqH3xUd4Sb9HUZy5XRvU2hqZ07I4kuE87ARxKtCmY21mBg2kQykV kbtM7HcHNqEojP0ZnopbTkM96eFqxEJBXiNBhsJI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730015AbgGMPv2 (ORCPT ); Mon, 13 Jul 2020 11:51:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:44860 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729644AbgGMPv2 (ORCPT ); Mon, 13 Jul 2020 11:51:28 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C938B20663; Mon, 13 Jul 2020 15:51:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594655488; bh=UeqdQ5Ai6a37CRGQJQSRCJSFMdVA0qgwG68F8CKF9Ds=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fttp4F/t7IrpungzsmZJbKuyfRK8ZJyiRWLDJMG8UGr0TkPdeYYiQT0w90lrzTN93 2hgezqA6OyjPncthC6dAIfyq/SnjICvycAwIlDEp39OmT4g/2I5uBDS7yYANpprCtd O+PvhCrvsecDYZe4LeB+BVPVu7yXeDK+xWus1uu8= Date: Mon, 13 Jul 2020 17:51:27 +0200 From: Greg Kroah-Hartman To: Johan Hovold Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] USB: serial: sierra: clean up special-interface handling Message-ID: <20200713155127.GA267581@kroah.com> References: <20200713153936.18032-1-johan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200713153936.18032-1-johan@kernel.org> Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Mon, Jul 13, 2020 at 05:39:36PM +0200, Johan Hovold wrote: > Clean up the handling of special interfaces that either should be > ignored or that need a larger number of URBs. > > Commit 66f092ed3b94 ("USB: serial: sierra: unify quirk handling logic") > replaced the previous is_blacklisted() and is_highmemory() helpers with > a single is_quirk() helper which made it even harder to understand what > the interface lists were used for. > > Rename the interface-list struct, its members and the interface-lookup > helper and restructure the code somewhat in order to make it more > self-explanatory. Much better, that was messy, thanks for cleaning this up. Reviewed-by: Greg Kroah-Hartman