From: Johan Hovold <johan@kernel.org>
To: "Allen Lee黎京倍" <li.jingbei@neoway.com>
Cc: Johan Hovold <johan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org
Subject: Re: [PATCH] USB: serial: option: Add support for Neoway N720
Date: Tue, 14 Jul 2020 09:27:04 +0200 [thread overview]
Message-ID: <20200714072704.GB22214@localhost> (raw)
In-Reply-To: <1594298156-21549-1-git-send-email-li.jingbei@neoway.com>
On Thu, Jul 09, 2020 at 08:35:56PM +0800, Allen Lee黎京倍 wrote:
> N720 is a Cat. 4 LTE modem. There are three interface
> mappings to meet different needs:
> ID 2949:8241(Rndis + Modem + Nmea + At_port + Diag + Rmnet)
> ID 2949:8243(Rmnet + Modem + Nmea + At_port + Diag + ADB)
> ID 2949:8247(Modem + Nmea + At_port + Diag + Rmnet)
> Signed-off-by: Jingbei Li <li.jingbei@neoway.com>
The name here doesn't match the From (author) name (and checkpatch.pl
complains).
> ---
> drivers/usb/serial/option.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index 8e74903..9191a24 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -524,6 +524,12 @@ static void option_instat_callback(struct urb *urb);
> #define MEDIATEK_PRODUCT_FPDC_1COM 0x0043
> #define MEDIATEK_PRODUCT_FPDC_2COM 0x0033
>
> +/* Neoway products */
> +#define NEOWAY_VENDOR_ID 0x2949
> +#define NEOWAY_PRODUCT_N720_8241 0x8241
> +#define NEOWAY_PRODUCT_N720_8243 0x8243
> +#define NEOWAY_PRODUCT_N720_8247 0x8247
Please drop these defines and add a short comment after the entry
instead as we're trying to move away from these mostly redundant
defines. Add your devices in numerical order towards the end of the
table.
> +
> /* Cellient products */
> #define CELLIENT_VENDOR_ID 0x2692
> #define CELLIENT_PRODUCT_MEN200 0x9005
> @@ -1972,6 +1978,13 @@ static const struct usb_device_id option_ids[] = {
> { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, MEDIATEK_PRODUCT_7106_2COM, 0x02, 0x02, 0x01) },
> { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, MEDIATEK_PRODUCT_DC_4COM2, 0xff, 0x02, 0x01) },
> { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, MEDIATEK_PRODUCT_DC_4COM2, 0xff, 0x00, 0x00) },
> + /* Neoway N720 4G Modem */
> + { USB_DEVICE(NEOWAY_VENDOR_ID, NEOWAY_PRODUCT_N720_8241),
> + .driver_info = RSVD(0) | RSVD(1) | RSVD(6) },
> + { USB_DEVICE(NEOWAY_VENDOR_ID, NEOWAY_PRODUCT_N720_8243),
> + .driver_info = RSVD(0) | RSVD(5) },
> + { USB_DEVICE(NEOWAY_VENDOR_ID, NEOWAY_PRODUCT_N720_8247),
> + .driver_info = RSVD(4) },
> { USB_DEVICE(CELLIENT_VENDOR_ID, CELLIENT_PRODUCT_MEN200) },
> { USB_DEVICE(PETATEL_VENDOR_ID, PETATEL_PRODUCT_NP10T_600A) },
> { USB_DEVICE(PETATEL_VENDOR_ID, PETATEL_PRODUCT_NP10T_600E) },
Johan
prev parent reply other threads:[~2020-07-14 7:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 12:35 [PATCH] USB: serial: option: Add support for Neoway N720 Allen Lee黎京倍
2020-07-14 7:27 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200714072704.GB22214@localhost \
--to=johan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=li.jingbei@neoway.com \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).