From: Greg KH <greg@kroah.com>
To: Wxcafé <wxcafe@wxcafe.net>
Cc: linux-usb@vger.kernel.org,
"Miguel Rodríguez Pérez" <miguel@det.uvigo.gal>,
oliver@neukum.org, netdev@vger.kernel.org
Subject: Re: [PATCH 1/4] cdc_ether: use dev->intf to get interface information
Date: Wed, 15 Jul 2020 18:02:33 +0200 [thread overview]
Message-ID: <20200715160233.GA761067@kroah.com> (raw)
In-Reply-To: <06493cccfe5d34f8052050e35073695ea0af6c0a.camel@wxcafe.net>
On Wed, Jul 15, 2020 at 11:53:39AM -0400, Wxcafé wrote:
> >From 0d0f13077e02cf6b54f2a22eb2e5f7d97ac7ee97 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Miguel Rodr=C3=ADguez P=C3=A9rez? <miguel@det.uvigo.gal>
> Date: Tue, 14 Jul 2020 18:02:10 -0400
> Subject: [PATCH 1/4] cdc_ether: use dev->intf to get interface information
That looks really odd in a changelog body :(
>
> usbnet_cdc_update_filter was getting the interface number from the
> usb_interface struct in cdc_state->control. However, cdc_ncm does
> not initialize that structure in its bind function, but uses
> cdc_ncm_cts instead. Getting intf directly from struct usbnet solves
> the problem.
>
> Signed-off-by: Miguel Rodríguez Pérez <miguel@det.uvigo.gal>
> Signed-off-by: Wxcafé <wxcafe@wxcafe.net>
As per the documentation, we need a "real name" for all signed-off-by.
Also, what has changed with this series from before? Have you addressed
Oliver's objections?
thanks,
greg k-h
next prev parent reply other threads:[~2020-07-15 16:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 15:53 [PATCH 1/4] cdc_ether: use dev->intf to get interface information Wxcafé
2020-07-15 16:02 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-07-15 1:23 Wxcafé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200715160233.GA761067@kroah.com \
--to=greg@kroah.com \
--cc=linux-usb@vger.kernel.org \
--cc=miguel@det.uvigo.gal \
--cc=netdev@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=wxcafe@wxcafe.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).