From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8392C433DF for ; Wed, 15 Jul 2020 16:04:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9C6BA2065E for ; Wed, 15 Jul 2020 16:04:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kroah.com header.i=@kroah.com header.b="HUGlRXL/"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="dz8ncD4B" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726780AbgGOQDh (ORCPT ); Wed, 15 Jul 2020 12:03:37 -0400 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:38807 "EHLO wout4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726660AbgGOQC6 (ORCPT ); Wed, 15 Jul 2020 12:02:58 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id F37EBBC0; Wed, 15 Jul 2020 12:02:40 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 15 Jul 2020 12:02:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:content-transfer-encoding:in-reply-to; s=fm1; bh=n MV+U3ZYC+YYO1JarfMEDenZhLZTIDP/xMrNIOtHFWg=; b=HUGlRXL/3MF5QUGPL CHzHV2++7oAa7NKrXur4jXx+w9nCLqS46If55ZLO4ChQ7j1fxh3KW5VLNEoTQS6Q yIwfLrYUkwOxVJij6AVNFgRgdf1VAmjy1cIOyQYVLxlZtc/NMr/tq4rJH6ptLfVc Bx9aq9lQ+MG/yKLuLcqR0D1kg9md9tYOxwEdpYUQ5wJIY2nBTReqKhRW09uM/Teb HGJ4YOuMHRTWkACvh0XEViZDjUBlNXtd23F8+gAKz70IoWqk+n8GwtPg5vm4asOR jyBKpgjPeTDR4exFDR+yer9Kv4HORhf3dq9Afx6O8nofuqDb+uTqIrOgKnVVu420 vKJ0g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=nMV+U3ZYC+YYO1JarfMEDenZhLZTIDP/xMrNIOtHF Wg=; b=dz8ncD4Bg8eSvAJlqerTs0hdtft5A6zXIjnnSjY/QwtI1yl9vUSXI8nBm xNaJtRc3fGJpbl7xW2mPIxsvLcVZJJfl/nU69TfAMCwka85tIqgLkclQL+BzSeJV 5y9kXOPxNf3YxTPGs0FwD0wPxDr2NZ4KI0UsFg2/1DSCMUgn+yb/CNde7gykSk9l jZu3IH6uhSlz7kbPX9PANqrgK6GMG74iSMXOeUUcolHWynQTwo9CxvvJ8F8h2+9O VuDZznjoU+c+BCUfkvND2WhPsasYyLusvkWbjkO+Ww5t2Y25Rkd4fP3HVP4KHGIo SY7F3ofE87bdtOo7A7GGLf35nG7fQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrfedvgddutdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtugfgjgesthekredttddtudenucfhrhhomhepifhrvghg ucfmjfcuoehgrhgvgheskhhrohgrhhdrtghomheqnecuggftrfgrthhtvghrnhepvedtie elueetgeeggfeufefhvefgtdetgfetgfdtvdegjeehieduvddtkeffheffnecukfhppeek fedrkeeirdekledruddtjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmh grihhlfhhrohhmpehgrhgvgheskhhrohgrhhdrtghomh X-ME-Proxy: Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) by mail.messagingengine.com (Postfix) with ESMTPA id 936043280059; Wed, 15 Jul 2020 12:02:38 -0400 (EDT) Date: Wed, 15 Jul 2020 18:02:33 +0200 From: Greg KH To: =?iso-8859-1?Q?Wxcaf=E9?= Cc: linux-usb@vger.kernel.org, Miguel =?iso-8859-1?Q?Rodr=EDguez_P=E9rez?= , oliver@neukum.org, netdev@vger.kernel.org Subject: Re: [PATCH 1/4] cdc_ether: use dev->intf to get interface information Message-ID: <20200715160233.GA761067@kroah.com> References: <06493cccfe5d34f8052050e35073695ea0af6c0a.camel@wxcafe.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <06493cccfe5d34f8052050e35073695ea0af6c0a.camel@wxcafe.net> Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Wed, Jul 15, 2020 at 11:53:39AM -0400, Wxcafé wrote: > >From 0d0f13077e02cf6b54f2a22eb2e5f7d97ac7ee97 Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?Miguel Rodr=C3=ADguez P=C3=A9rez? > Date: Tue, 14 Jul 2020 18:02:10 -0400 > Subject: [PATCH 1/4] cdc_ether: use dev->intf to get interface information That looks really odd in a changelog body :( > > usbnet_cdc_update_filter was getting the interface number from the > usb_interface struct in cdc_state->control. However, cdc_ncm does > not initialize that structure in its bind function, but uses > cdc_ncm_cts instead. Getting intf directly from struct usbnet solves > the problem. > > Signed-off-by: Miguel Rodríguez Pérez > Signed-off-by: Wxcafé As per the documentation, we need a "real name" for all signed-off-by. Also, what has changed with this series from before? Have you addressed Oliver's objections? thanks, greg k-h