linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Angelo Dureghello <angelo.dureghello@timesys.com>, johan@kernel.org
Cc: kbuild-all@lists.01.org, linux-usb@vger.kernel.org,
	Angelo Dureghello <angelo.dureghello@timesys.com>
Subject: Re: [PATCH] USB: serial: add support for MaxLinear XR21V1412
Date: Sun, 19 Jul 2020 08:24:52 +0800	[thread overview]
Message-ID: <202007190835.p4UGRBkz%lkp@intel.com> (raw)
In-Reply-To: <20200709010008.2784747-1-angelo.dureghello@timesys.com>

[-- Attachment #1: Type: text/plain, Size: 3071 bytes --]

Hi Angelo,

I love your patch! Perhaps something to improve:

[auto build test WARNING on usb-serial/usb-next]
[also build test WARNING on peter.chen-usb/ci-for-usb-next balbi-usb/testing/next usb/usb-testing v5.8-rc5 next-20200717]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Angelo-Dureghello/USB-serial-add-support-for-MaxLinear-XR21V1412/20200709-085509
base:   https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git usb-next
config: s390-randconfig-s032-20200719 (attached as .config)
compiler: s390-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.2-49-g707c5017-dirty
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=s390 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)

   drivers/usb/serial/xr21v1412.c:71:9: sparse: sparse: preprocessor token PARITY_NONE redefined
>> include/uapi/linux/hdlc/ioctl.h:24:9: sparse: this was the original definition
   drivers/usb/serial/xr21v1412.c:149:42: sparse: sparse: Using plain integer as NULL pointer

vim +24 include/uapi/linux/hdlc/ioctl.h

eb2a2fd91f7c8a include/linux/hdlc/ioctl.h Krzysztof Halasa 2006-09-26  21  
eb2a2fd91f7c8a include/linux/hdlc/ioctl.h Krzysztof Halasa 2006-09-26  22  
eb2a2fd91f7c8a include/linux/hdlc/ioctl.h Krzysztof Halasa 2006-09-26  23  #define PARITY_DEFAULT		0 /* Default setting */
eb2a2fd91f7c8a include/linux/hdlc/ioctl.h Krzysztof Halasa 2006-09-26 @24  #define PARITY_NONE		1 /* No parity */
eb2a2fd91f7c8a include/linux/hdlc/ioctl.h Krzysztof Halasa 2006-09-26  25  #define PARITY_CRC16_PR0	2 /* CRC16, initial value 0x0000 */
eb2a2fd91f7c8a include/linux/hdlc/ioctl.h Krzysztof Halasa 2006-09-26  26  #define PARITY_CRC16_PR1	3 /* CRC16, initial value 0xFFFF */
eb2a2fd91f7c8a include/linux/hdlc/ioctl.h Krzysztof Halasa 2006-09-26  27  #define PARITY_CRC16_PR0_CCITT	4 /* CRC16, initial 0x0000, ITU-T version */
eb2a2fd91f7c8a include/linux/hdlc/ioctl.h Krzysztof Halasa 2006-09-26  28  #define PARITY_CRC16_PR1_CCITT	5 /* CRC16, initial 0xFFFF, ITU-T version */
eb2a2fd91f7c8a include/linux/hdlc/ioctl.h Krzysztof Halasa 2006-09-26  29  #define PARITY_CRC32_PR0_CCITT	6 /* CRC32, initial value 0x00000000 */
eb2a2fd91f7c8a include/linux/hdlc/ioctl.h Krzysztof Halasa 2006-09-26  30  #define PARITY_CRC32_PR1_CCITT	7 /* CRC32, initial value 0xFFFFFFFF */
eb2a2fd91f7c8a include/linux/hdlc/ioctl.h Krzysztof Halasa 2006-09-26  31  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 27377 bytes --]

      parent reply	other threads:[~2020-07-19  0:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-09  1:00 [PATCH] USB: serial: add support for MaxLinear XR21V1412 Angelo Dureghello
2020-07-09  5:57 ` kernel test robot
2020-07-14 14:43 ` kernel test robot
2020-07-19  0:24 ` kernel test robot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202007190835.p4UGRBkz%lkp@intel.com \
    --to=lkp@intel.com \
    --cc=angelo.dureghello@timesys.com \
    --cc=johan@kernel.org \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).