linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: usbfs: stop using compat_alloc_user_space
Date: Wed, 22 Jul 2020 10:09:59 +0200	[thread overview]
Message-ID: <20200722080959.GA2800885@kroah.com> (raw)
In-Reply-To: <20200722073655.220011-1-hch@lst.de>

On Wed, Jul 22, 2020 at 09:36:55AM +0200, Christoph Hellwig wrote:
> Just switch the low-level routines to take kernel structures, and do the
> conversion from the compat to the native structure on that.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  drivers/usb/core/devio.c | 126 +++++++++++++++++++++------------------
>  1 file changed, 69 insertions(+), 57 deletions(-)

No objection to this, but why?  Are you trying to get rid of
compat_alloc_user_space()?

And do you want me to take this through my tree, or do you need to take
it through yours?

thanks,

greg k-h

  reply	other threads:[~2020-07-22  8:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-22  7:36 [PATCH] usb: usbfs: stop using compat_alloc_user_space Christoph Hellwig
2020-07-22  8:09 ` Greg KH [this message]
2020-07-22  8:21   ` Christoph Hellwig
2020-07-22 11:13     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200722080959.GA2800885@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=hch@lst.de \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).