From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22BADC433E3 for ; Wed, 22 Jul 2020 10:35:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ED02820787 for ; Wed, 22 Jul 2020 10:35:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595414119; bh=y71mKkT0E5cTPJDXaqrS65YDrnae2c7rwl5cjCPbJCw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=hUiCdz3v/u1PE5zWzTIFxX5dayEIW3G/Fx3t6GYrAK/aappU8mRnjmlMLH3Q9lLTt 1aINkMWFSstBZknYnpndJG94ftwlC9f+aQ8kYIDUoPgYzlQmY20bbiF3OB8oLsrLUg eltRrxKrCy49sg6WpG9HRk4A6wfU99UtjbfOSA5I= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731990AbgGVKfS (ORCPT ); Wed, 22 Jul 2020 06:35:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:46840 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726153AbgGVKfS (ORCPT ); Wed, 22 Jul 2020 06:35:18 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 35CC120656; Wed, 22 Jul 2020 10:35:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595414117; bh=y71mKkT0E5cTPJDXaqrS65YDrnae2c7rwl5cjCPbJCw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=v/JEU7VDDRAYJhXZxn//+X7M07NtwuPfvbiuxtF3HB8WIqKolilqIXjmecQsCvps+ fcyvLhSVn8mHmAfA8FajdE42qqA6BBQNQImrUb0fmWll/YZbCN4uP4bUOkVKTfCWQN Qt3FzrNGCd/pSrmXJi3wrqw+8pONUEIXFWap3e3k= Date: Wed, 22 Jul 2020 12:35:23 +0200 From: Greg Kroah-Hartman To: Bastien Nocera Cc: linux-usb@vger.kernel.org, Alan Stern Subject: Re: [PATCH 2/2] USB: Fix source path in header Message-ID: <20200722103523.GB2824871@kroah.com> References: <20200722094628.4236-1-hadess@hadess.net> <20200722094628.4236-2-hadess@hadess.net> <20200722095102.GA2816153@kroah.com> <76c0e527095fd3adbf802e9a27ba93cbd656a03b.camel@hadess.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <76c0e527095fd3adbf802e9a27ba93cbd656a03b.camel@hadess.net> Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Wed, Jul 22, 2020 at 11:58:54AM +0200, Bastien Nocera wrote: > On Wed, 2020-07-22 at 11:51 +0200, Greg Kroah-Hartman wrote: > > On Wed, Jul 22, 2020 at 11:46:28AM +0200, Bastien Nocera wrote: > > > Signed-off-by: Bastien Nocera > > > > I can't take patches without any changelog text at all, sorry. > > The subject line isn't clear enough? Maybe, maybe not, doesn't mean you shouldn't also write some text about why you did what you did. > > > --- > > > drivers/usb/core/driver.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/usb/core/driver.c b/drivers/usb/core/driver.c > > > index a6187dd2186c..bd346e683af3 100644 > > > --- a/drivers/usb/core/driver.c > > > +++ b/drivers/usb/core/driver.c > > > @@ -1,6 +1,6 @@ > > > // SPDX-License-Identifier: GPL-2.0 > > > /* > > > - * drivers/usb/driver.c - most of the driver model stuff for usb > > > + * drivers/usb/core/driver.c - most of the driver model stuff for > > > usb > > > > Just drop the whole file name, it's not needed at all. > > And the description after or just the filename? The description is fine to keep. thanks, greg k-h