From: Mark Brown <broonie@kernel.org>
To: Vincent Whitchurch <vincent.whitchurch@axis.com>
Cc: Mike Looijmans <mike.looijmans@topic.nl>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
balbi@kernel.org, gregkh@linuxfoundation.org,
lgirdwood@gmail.com
Subject: Re: [PATCH v3] usb: dwc3: Add support for VBUS power control
Date: Thu, 23 Jul 2020 12:05:23 +0100 [thread overview]
Message-ID: <20200723110523.GA4759@sirena.org.uk> (raw)
In-Reply-To: <20200723075612.tn5dbkhes2chohwh@axis.com>
[-- Attachment #1: Type: text/plain, Size: 760 bytes --]
On Thu, Jul 23, 2020 at 09:56:14AM +0200, Vincent Whitchurch wrote:
> On Fri, Jun 19, 2020 at 04:25:12PM +0200, Mike Looijmans wrote:
> > +void dwc3_set_vbus(struct dwc3 *dwc, bool enable)
> > +{
> > + int ret;
> > +
> > + if (enable != dwc->vbus_reg_enabled) {
> > + if (enable)
> > + ret = regulator_enable(dwc->vbus_reg);
> > + else
> > + ret = regulator_disable(dwc->vbus_reg);
> dwc->vbus_reg is set to NULL when the regulator is not present. These
> regulator_* functions expect a non-NULL pointer so a NULL check is
> required before calling them.
Does the device actually support running without power so that's a thing
that can happen? _get_optional() should only ever be used for supplies
that may be physically absent.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-07-23 11:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-19 14:25 [PATCH v3] usb: dwc3: Add support for VBUS power control Mike Looijmans
2020-07-23 7:56 ` Vincent Whitchurch
2020-07-23 11:05 ` Mark Brown [this message]
[not found] ` <1b153bce-a66a-45ee-a5c6-963ea6fb1c82.949ef384-8293-46b8-903f-40a477c056ae.2698920d-90ba-4c46-abda-83e18e2093c8@emailsignatures365.codetwo.com>
[not found] ` <1b153bce-a66a-45ee-a5c6-963ea6fb1c82.0d2bd5fa-15cc-4b27-b94e-83614f9e5b38.ac9c2a67-d7df-4f70-81b3-db983bbfb4db@emailsignatures365.codetwo.com>
2020-07-26 7:10 ` Mike Looijmans
2020-07-27 10:23 ` Mark Brown
2020-07-27 11:50 ` Mike Looijmans
2020-07-27 11:53 ` Mark Brown
2020-07-28 7:29 ` Mike Looijmans
2020-09-07 7:44 ` Felipe Balbi
2020-09-07 7:50 ` Mike Looijmans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200723110523.GA4759@sirena.org.uk \
--to=broonie@kernel.org \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mike.looijmans@topic.nl \
--cc=vincent.whitchurch@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).