From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC62DC433E0 for ; Fri, 24 Jul 2020 16:32:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 88281206EB for ; Fri, 24 Jul 2020 16:32:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595608335; bh=Wu2M+P+zLSH1QV4Giv5fhpeU8je67kqtz8vmJQLi3/I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=KPBes6jHIsIPzHZ1eoNRMrfBBPsQEi1Pnz2Wx0Za+Pr64q8GhhsfLeq7uCGa2cS9i FYHixPPzodYo/DPzviniB8itix3rTT9lcRt1v4ehFc9Uf1tPFO3l6Lp4/N8JNdfytd 7yyCgJY5+KLwmdkW305WbD8wPHScoSmdPLeHnMiU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726424AbgGXQcP (ORCPT ); Fri, 24 Jul 2020 12:32:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:53194 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726317AbgGXQcO (ORCPT ); Fri, 24 Jul 2020 12:32:14 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CE2A5206D8; Fri, 24 Jul 2020 16:32:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595608334; bh=Wu2M+P+zLSH1QV4Giv5fhpeU8je67kqtz8vmJQLi3/I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ODrtc6EcKksQ4acJLxYHw4/EQ9dbraxCzGryTdcIWOCgwDcAmn3nceXt5O80GJ0b+ 7zs28U7fpcITpEU/1It2KuG2dilbeDPpgqHoVv7k9f+fybJoleh29uA489wpBdV/i0 PtMgOnF52xv31j9fRmmPlweOQdv0l1/HNu/YeCpU= Date: Fri, 24 Jul 2020 18:32:15 +0200 From: Greg KH To: Mathias Nyman Cc: linux-usb@vger.kernel.org Subject: Re: [PATCH 00/27] xhci features for usb-next Message-ID: <20200724163215.GA543850@kroah.com> References: <20200723144530.9992-1-mathias.nyman@linux.intel.com> <20200723150411.GA2529859@kroah.com> <20200724070643.GH3880088@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Fri, Jul 24, 2020 at 02:11:44PM +0300, Mathias Nyman wrote: > > What other interface is asked for? And yes, I would push back, what is > > wrong with TTY here? It should be the most "low overhead" interface > > that works with common userspace tools that we have. > > I've been asking the same questions about the TTY limitations. > > Currently there's a driver providing a character device in development. > The developers are aware that they need to clarify and justify the need for a > new interface to get the driver upstream. My concerns and suggestions are noted. > > As I don't understand these TTY limitations I'll have to let people publishing the > driver do this part. I expect that the driver will clarify things. > > Anyway, I rather support them and work on providing the infrastructure needed > to write such a driver, and give them the opportunity to implement whatever is needed. Don't add frameworks for no users. Making this a char driver is not going to fly with me, I think I remember seeing old patches that tried to do this in the past that were submitted to some random Android kernel, and they just did not make any sense. It is easier to hide custom ioctls (i.e. custom syscalls) in a char driver than it is in a tty driver, so don't fall into that trap :) good luck! greg k-h