From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Bastien Nocera <hadess@hadess.net>
Cc: linux-usb@vger.kernel.org, Alan Stern <stern@rowland.harvard.edu>
Subject: Re: [PATCH v6 3/3] USB: Fix device driver race
Date: Tue, 4 Aug 2020 13:56:33 +0200 [thread overview]
Message-ID: <20200804115633.GA203147@kroah.com> (raw)
In-Reply-To: <8f1de4cc2813f0a8721a2f76421956056c0c6278.camel@hadess.net>
On Tue, Aug 04, 2020 at 01:41:25PM +0200, Bastien Nocera wrote:
> On Mon, 2020-08-03 at 17:38 +0200, Greg Kroah-Hartman wrote:
> > On Mon, Aug 03, 2020 at 05:04:46PM +0200, Bastien Nocera wrote:
> > > On Mon, 2020-07-27 at 12:46 +0200, Bastien Nocera wrote:
> > > > When a new device with a specialised device driver is plugged in,
> > > > the
> > > > new driver will be modprobe()'d but the driver core will attach
> > > > the
> > > > "generic" driver to the device.
> > > >
> > > > After that, nothing will trigger a reprobe when the modprobe()'d
> > > > device
> > > > driver has finished initialising, as the device has the "generic"
> > > > driver attached to it.
> > > >
> > > > Trigger a reprobe ourselves when new specialised drivers get
> > > > registered.
> > > >
> > > > Fixes: 88b7381a939d ("USB: Select better matching USB drivers
> > > > when
> > > > available")
> > > > Signed-off-by: Bastien Nocera <hadess@hadess.net>
> > >
> > > Greg, Alan, are you happy with this iteration?
> > >
> > > If so, I can send it again with Alan's acks, along with a fix for
> > > the
> > > function name Alan mentioned. I see that the first patch in the
> > > list
> > > landed in usb-next already.
> > >
> >
> > Yes, please resend the remaining patches. I don't recall seeing
> > Alan's
> > ack on it.
>
> Resent as v7. There's a new patch in the lot, based on a comment by
> Alan in this thread which I thought appropriate to include.
Thanks, will look at them once 5.9-rc1 is out as I can't do anything
with my tree until then.
greg k-h
next prev parent reply other threads:[~2020-08-04 11:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 10:46 [PATCH v6 1/3] USB: Simplify USB ID table match Bastien Nocera
2020-07-27 10:46 ` [PATCH v6 2/3] USB: Also check for ->match Bastien Nocera
2020-07-27 10:46 ` [PATCH v6 3/3] USB: Fix device driver race Bastien Nocera
2020-08-03 15:04 ` Bastien Nocera
2020-08-03 15:38 ` Greg Kroah-Hartman
2020-08-04 11:41 ` Bastien Nocera
2020-08-04 11:56 ` Greg Kroah-Hartman [this message]
2020-08-03 16:02 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200804115633.GA203147@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=hadess@hadess.net \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox