linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Peter Chen <peter.chen@nxp.com>
Cc: "balbi@kernel.org" <balbi@kernel.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	dl-linux-imx <linux-imx@nxp.com>,
	"stern@rowland.harvard.edu" <stern@rowland.harvard.edu>,
	Anton Vasilyev <vasilyev@ispras.ru>,
	Evgeny Novikov <novikov@ispras.ru>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: [PATCH 1/6] USB: UDC: Expand device model API interface
Date: Fri, 7 Aug 2020 12:37:06 +0200	[thread overview]
Message-ID: <20200807103706.GA3096754@kroah.com> (raw)
In-Reply-To: <AM7PR04MB7157A52930B8F6D0CD38BE2A8B490@AM7PR04MB7157.eurprd04.prod.outlook.com>

On Fri, Aug 07, 2020 at 10:21:53AM +0000, Peter Chen wrote:
>  
> > 
> > On Fri, Aug 07, 2020 at 05:41:46PM +0800, Peter Chen wrote:
> > > From: Alan Stern <stern@rowland.harvard.edu>
> > >
> > > The routines used by the UDC core to interface with the kernel's
> > > device model, namely usb_add_gadget_udc(),
> > > usb_add_gadget_udc_release(), and usb_del_gadget_udc(), provide access
> > > to only a subset of the device model's full API.  They include
> > > functionality equivalent to device_register() and device_unregister()
> > > for gadgets, but they omit device_initialize(), device_add(),
> > > device_del(), get_device(), and put_device().
> > >
> > > This patch expands the UDC API by adding usb_initialize_gadget(),
> > > usb_add_gadget(), usb_del_gadget(), usb_get_gadget(), and
> > > usb_put_gadget() to fill in the gap.  It rewrites the existing
> > > routines to call the new ones.
> > >
> > > CC: Anton Vasilyev <vasilyev@ispras.ru>
> > > CC: Evgeny Novikov <novikov@ispras.ru>
> > > CC: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > > Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
> > 
> > You can not forward on patches from someone else without also signing off on
> > them.
> > 
>  
> So, even without contribution for the patch, we also need to add signing off when
> submit?

Please read the DCO, you are submitting some else's work here, it is
passing through you, you need to add your s-o-b to it.  It's only been
this way since the very beginning :)

thanks,

greg k-h

  reply	other threads:[~2020-08-07 10:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-07  9:41 [PATCH 0/6] USB: UDC: Fix memory leaks by expanding the API Peter Chen
2020-08-07  9:41 ` [PATCH 1/6] USB: UDC: Expand device model API interface Peter Chen
2020-08-07  9:52   ` Greg KH
2020-08-07 10:21     ` Peter Chen
2020-08-07 10:37       ` Greg KH [this message]
2020-08-07  9:41 ` [PATCH 2/6] USB: UDC: net2280: Fix memory leaks Peter Chen
2020-08-07 13:59   ` Alan Stern
2020-08-07  9:41 ` [PATCH 3/6] USB: UDC: net2272: " Peter Chen
2020-08-07  9:41 ` [PATCH 4/6] usb: cdns3: gadget: fix possible memory leak Peter Chen
2020-08-07  9:41 ` [PATCH 5/6] usb: dwc3: allocate gadget structure dynamically Peter Chen
2020-08-07  9:41 ` [PATCH 6/6] Revert "usb: udc: allow adding and removing the same gadget device" Peter Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200807103706.GA3096754@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=balbi@kernel.org \
    --cc=benh@kernel.crashing.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=novikov@ispras.ru \
    --cc=peter.chen@nxp.com \
    --cc=stern@rowland.harvard.edu \
    --cc=vasilyev@ispras.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).