From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50C10C433DF for ; Fri, 7 Aug 2020 10:36:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2604C20866 for ; Fri, 7 Aug 2020 10:36:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596796615; bh=F0K6LJGkZfyqbux2jSIoh8HvDGyzM8YFaNJW6MnYlnc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=oQXAg+HviVFXDmCAzEw50Pq8G2a//B44jbY3S3pVhdcQljN5Cp1FqfquFV9JNHicT PTEEad2IjBpkDIVvlwPaFl8maWo7LsmeYQtoh+5XrW9STZrLokSrd6sidrfeGz2X0Y 862zg9KPfC/UDsyS3YkgJ4RfmLfhvjga2qw2SjVk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727928AbgHGKgy (ORCPT ); Fri, 7 Aug 2020 06:36:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:54594 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726511AbgHGKgy (ORCPT ); Fri, 7 Aug 2020 06:36:54 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1B9742075D; Fri, 7 Aug 2020 10:36:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596796613; bh=F0K6LJGkZfyqbux2jSIoh8HvDGyzM8YFaNJW6MnYlnc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CMwQBpjejIIJcZIoG+VOne2a4rDQPIlv5k6xNIog9oPHbXadG/bJT5yA1WDUhAsZD JgUJKROrn/n/NYMOGnkUX9qaS8U3CsplVAOVLWJx6A6qwZ2zaivBp1b0HsXbyy6zg2 72F4QMDMUxI8xJJ2k2TF9N3SURSoqKsZZGH59iW8= Date: Fri, 7 Aug 2020 12:37:06 +0200 From: Greg KH To: Peter Chen Cc: "balbi@kernel.org" , "linux-usb@vger.kernel.org" , dl-linux-imx , "stern@rowland.harvard.edu" , Anton Vasilyev , Evgeny Novikov , Benjamin Herrenschmidt Subject: Re: [PATCH 1/6] USB: UDC: Expand device model API interface Message-ID: <20200807103706.GA3096754@kroah.com> References: <20200807094151.13526-1-peter.chen@nxp.com> <20200807094151.13526-2-peter.chen@nxp.com> <20200807095221.GA3071081@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Fri, Aug 07, 2020 at 10:21:53AM +0000, Peter Chen wrote: > > > > > On Fri, Aug 07, 2020 at 05:41:46PM +0800, Peter Chen wrote: > > > From: Alan Stern > > > > > > The routines used by the UDC core to interface with the kernel's > > > device model, namely usb_add_gadget_udc(), > > > usb_add_gadget_udc_release(), and usb_del_gadget_udc(), provide access > > > to only a subset of the device model's full API. They include > > > functionality equivalent to device_register() and device_unregister() > > > for gadgets, but they omit device_initialize(), device_add(), > > > device_del(), get_device(), and put_device(). > > > > > > This patch expands the UDC API by adding usb_initialize_gadget(), > > > usb_add_gadget(), usb_del_gadget(), usb_get_gadget(), and > > > usb_put_gadget() to fill in the gap. It rewrites the existing > > > routines to call the new ones. > > > > > > CC: Anton Vasilyev > > > CC: Evgeny Novikov > > > CC: Benjamin Herrenschmidt > > > Signed-off-by: Alan Stern > > > > You can not forward on patches from someone else without also signing off on > > them. > > > > So, even without contribution for the patch, we also need to add signing off when > submit? Please read the DCO, you are submitting some else's work here, it is passing through you, you need to add your s-o-b to it. It's only been this way since the very beginning :) thanks, greg k-h