linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Chen <peter.chen@nxp.com>
To: mathias.nyman@intel.com
Cc: linux-usb@vger.kernel.org, gregkh@linuxfoundation.org,
	linux-imx@nxp.com, Peter Chen <peter.chen@nxp.com>
Subject: [PATCH v2 6/7] usb: host: xhci-plat: improve the comments for xhci_plat_suspend
Date: Mon, 17 Aug 2020 17:44:39 +0800	[thread overview]
Message-ID: <20200817094440.23202-7-peter.chen@nxp.com> (raw)
In-Reply-To: <20200817094440.23202-1-peter.chen@nxp.com>

To reflect the current code status.

Signed-off-by: Peter Chen <peter.chen@nxp.com>
---
 drivers/usb/host/xhci-plat.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
index cfca6fc8947c..aa2d35f98200 100644
--- a/drivers/usb/host/xhci-plat.c
+++ b/drivers/usb/host/xhci-plat.c
@@ -421,11 +421,7 @@ static int __maybe_unused xhci_plat_suspend(struct device *dev)
 		return ret;
 	/*
 	 * xhci_suspend() needs `do_wakeup` to know whether host is allowed
-	 * to do wakeup during suspend. Since xhci_plat_suspend is currently
-	 * only designed for system suspend, device_may_wakeup() is enough
-	 * to dertermine whether host is allowed to do wakeup. Need to
-	 * reconsider this when xhci_plat_suspend enlarges its scope, e.g.,
-	 * also applies to runtime suspend.
+	 * to do wakeup during suspend.
 	 */
 	return xhci_suspend(xhci, device_may_wakeup(dev));
 }
-- 
2.17.1


  parent reply	other threads:[~2020-08-17  9:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-17  9:44 [PATCH v2 0/7] usb: host: xhci: some changes for xhci-plat.c Peter Chen
2020-08-17  9:44 ` [PATCH v2 1/7] usb: host: xhci-plat: add platform data support Peter Chen
2020-08-17  9:44 ` [PATCH v2 2/7] usb: host: xhci-plat: add .suspend_quirk for struct xhci_plat_priv Peter Chen
2020-08-17  9:44 ` [PATCH v2 3/7] usb: host: xhci-plat: delete the unnecessary code Peter Chen
2020-08-17  9:44 ` [PATCH v2 4/7] usb: host: xhci-plat: add priv quirk for skip PHY initialization Peter Chen
2020-08-17  9:44 ` [PATCH v2 5/7] usb: host: xhci-plat: add wakeup entry at sysfs Peter Chen
2020-08-21  9:37   ` Mathias Nyman
2020-08-21  9:57     ` Peter Chen
2020-08-21 10:35       ` Mathias Nyman
2020-09-17 17:49   ` Matthias Kaehlcke
2020-08-17  9:44 ` Peter Chen [this message]
2020-08-17  9:44 ` [PATCH v2 7/7] usb: host: xhci: avoid calling contineous two times for xhci_suspend Peter Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200817094440.23202-7-peter.chen@nxp.com \
    --to=peter.chen@nxp.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).