From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sergei Shtylyov <sergei.shtylyov@gmail.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Bastien Nocera <hadess@hadess.net>,
linux-usb@vger.kernel.org
Subject: Re: [PATCH v8 3/3] USB: Fix device driver race
Date: Wed, 19 Aug 2020 07:55:03 +0200 [thread overview]
Message-ID: <20200819055503.GC853200@kroah.com> (raw)
In-Reply-To: <a4e87e78-7ce4-efaa-55a7-7fe7c33094c5@gmail.com>
On Tue, Aug 18, 2020 at 11:49:43PM +0300, Sergei Shtylyov wrote:
> On 8/18/20 8:29 PM, Alan Stern wrote:
>
> >>> + } else {
> >>> printk(KERN_ERR "%s: error %d registering device "
> >>> " driver %s\n",
> >>
> >> Unrelated but... hm, this string literal seems weird. GregKH, would it be OK if we fix it?
> >>
> >>> usbcore_name, retval, new_udriver->name);
> >
> > Indeed, an extra tab character snuck in there by mistake. It has been
> > present ever since 2006, when the routine was originally added by commit
> > 8bb54ab573ec ("usbcore: add usb_device_driver definition").
>
> And meanwhile it got copied to another function, usb_register_driver().
> I guess it's OK to fix both w/one patch?
Yes.
prev parent reply other threads:[~2020-08-19 5:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-18 11:04 [PATCH v8 1/3] USB: Also match device drivers using the ->match vfunc Bastien Nocera
2020-08-18 11:04 ` [PATCH v8 2/3] USB: Better name for __check_usb_generic() Bastien Nocera
2020-08-18 11:04 ` [PATCH v8 3/3] USB: Fix device driver race Bastien Nocera
2020-08-18 17:06 ` Sergei Shtylyov
2020-08-18 17:25 ` Greg Kroah-Hartman
2020-08-18 17:29 ` Alan Stern
2020-08-18 20:49 ` Sergei Shtylyov
2020-08-19 5:55 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200819055503.GC853200@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=hadess@hadess.net \
--cc=linux-usb@vger.kernel.org \
--cc=sergei.shtylyov@gmail.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).