From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Yehezkel Bernat <yehezkelshb@gmail.com>
Cc: linux-usb@vger.kernel.org,
Michael Jamet <michael.jamet@intel.com>,
Andreas Noever <andreas.noever@gmail.com>,
"Nikunj A . Dadhania" <nikunj.dadhania@linux.intel.com>,
Srikanth Nandamuri <srikanth.nandamuri@intel.com>,
Lukas Wunner <lukas@wunner.de>
Subject: Re: [PATCH 1/2] thunderbolt: Disable ports that are not implemented
Date: Wed, 19 Aug 2020 15:45:12 +0300 [thread overview]
Message-ID: <20200819124512.GJ1375436@lahna.fi.intel.com> (raw)
In-Reply-To: <CA+CmpXs+WHj_PS51s=nOAJp9pvn6atDhVi0FtNasHfqqJ9MhXw@mail.gmail.com>
On Wed, Aug 19, 2020 at 02:54:39PM +0300, Yehezkel Bernat wrote:
> > - * @disabled: Disabled by eeprom
> > + * @disabled: Disabled by eeprom or enabled, but not implemented
>
> I'm not a native speaker, so I'm not sure about it, but maybe the comma here is
> superfluous and just confuses the reader. To me it looks like it means
> "(disabled
> || enabled) && !implemented" instead of "disabled || (enabled && !implemented)".
> Any opinion?
For me (also non-native speaker) I don't see a difference but sure I can
remove it :)
next prev parent reply other threads:[~2020-08-19 12:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-19 11:27 [PATCH 1/2] thunderbolt: Disable ports that are not implemented Mika Westerberg
2020-08-19 11:27 ` [PATCH 2/2] thunderbolt: Use maximum USB3 link rate when reclaiming if link is not up Mika Westerberg
2020-08-25 8:32 ` Mika Westerberg
2020-08-19 11:54 ` [PATCH 1/2] thunderbolt: Disable ports that are not implemented Yehezkel Bernat
2020-08-19 12:45 ` Mika Westerberg [this message]
2020-08-20 12:01 ` Nikunj A. Dadhania
2020-08-25 8:32 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200819124512.GJ1375436@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andreas.noever@gmail.com \
--cc=linux-usb@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=michael.jamet@intel.com \
--cc=nikunj.dadhania@linux.intel.com \
--cc=srikanth.nandamuri@intel.com \
--cc=yehezkelshb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).