linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Cyril Roelandt <tipecaml@gmail.com>
To: linux-usb@vger.kernel.org
Cc: stern@rowland.harvard.edu, sellis@redhat.com,
	pachoramos@gmail.com, labbott@fedoraproject.org, javhera@gmx.com,
	brice.goglin@gmail.com, Cyril Roelandt <tipecaml@gmail.com>,
	stable@vger.kernel.org
Subject: [PATCH] Ignore UAS for JMicron JMS567 ATA/ATAPI Bridge
Date: Mon, 24 Aug 2020 19:31:28 +0200	[thread overview]
Message-ID: <20200824173128.48740-1-tipecaml@gmail.com> (raw)
In-Reply-To: <20200824074027.GB3983120@kroah.com>

This device does not support UAS properly and a similar entry already
exists in drivers/usb/storage/unusual_uas.h. Without this patch,
storage_probe() defers the handling of this device to UAS, which cannot
handle it either.

Tested-by: Brice Goglin <brice.goglin@gmail.com>
CC: <stable@vger.kernel.org>
---
 drivers/usb/storage/unusual_devs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
index 220ae2c356ee..5732e9691f08 100644
--- a/drivers/usb/storage/unusual_devs.h
+++ b/drivers/usb/storage/unusual_devs.h
@@ -2328,7 +2328,7 @@ UNUSUAL_DEV(  0x357d, 0x7788, 0x0114, 0x0114,
 		"JMicron",
 		"USB to ATA/ATAPI Bridge",
 		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
-		US_FL_BROKEN_FUA ),
+		US_FL_BROKEN_FUA | US_FL_IGNORE_UAS ),
 
 /* Reported by Andrey Rahmatullin <wrar@altlinux.org> */
 UNUSUAL_DEV(  0x4102, 0x1020, 0x0100,  0x0100,
-- 
2.28.0


  reply	other threads:[~2020-08-24 17:32 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-15 20:56 [BUG] Regression in Linux 5.4.17 for JMicron JMS566 enclosure Cyril Roelandt
2020-04-16  1:21 ` Alan Stern
     [not found]   ` <CABLbxQ2Hoq8zt--w2FwuMa6FRCC72E5a-tvGRQOm=C0YF7bfqA@mail.gmail.com>
2020-04-16 14:43     ` Pacho Ramos
2020-04-17 18:32   ` Cyril Roelandt
2020-04-17 20:06     ` Alan Stern
2020-04-17 22:09       ` Cyril Roelandt
2020-04-19 16:03         ` Alan Stern
2020-04-21  3:01           ` Cyril Roelandt
2020-04-21 13:58             ` Alan Stern
2020-08-15  0:18             ` Cyril Roelandt
2020-08-15  2:19               ` Alan Stern
2020-08-15 23:23                 ` Cyril Roelandt
2020-08-16 16:26                   ` Alan Stern
2020-08-18  4:13                     ` Cyril Roelandt
2020-08-18 14:57                       ` Alan Stern
2020-08-23  1:30                         ` Cyril Roelandt
2020-08-23 14:47                           ` Alan Stern
2020-08-23 18:08                             ` Cyril Roelandt
2020-08-23 22:14                               ` Brice Goglin
2020-08-24  7:40                               ` Greg KH
2020-08-24 17:31                                 ` Cyril Roelandt [this message]
2020-08-24 20:18                                   ` [PATCH] Ignore UAS for JMicron JMS567 ATA/ATAPI Bridge Alan Stern
2020-08-25 21:22                                     ` [PATCH v2] " Cyril Roelandt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200824173128.48740-1-tipecaml@gmail.com \
    --to=tipecaml@gmail.com \
    --cc=brice.goglin@gmail.com \
    --cc=javhera@gmx.com \
    --cc=labbott@fedoraproject.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=pachoramos@gmail.com \
    --cc=sellis@redhat.com \
    --cc=stable@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).