From: Lorenzo Colitti <lorenzo@google.com>
To: linux-usb@vger.kernel.org
Cc: balbi@kernel.org, gregkh@linuxfoundation.org, zenczykowski@gmail.com
Subject: [PATCH v3 0/3] usb: gadget: f_ncm: support SuperSpeed Plus, improve on SuperSpeed
Date: Tue, 25 Aug 2020 14:55:02 +0900 [thread overview]
Message-ID: <20200825055505.765782-1-lorenzo@google.com> (raw)
This patch series makes the NCM gadget usable at SuperSpeed Plus
speeds (currently, it crashes with an oops). It also improves the
behaviour on SuperSpeed and above by making simple performance
improvements and by fixing the speeds that are reported to the
host (currently 851 Mbps, which is much below actual throughput).
Tested on a gadget directly connected to a Linux laptop running
5.6.14 and cdc_ncm, using both 5 Gbps and 10 Gbps cables. iperf3
single TCP connection throughput (gadget to host) is > 2 Gbps on
SuperSpeed and > 4 Gbps on SuperSpeed Plus.
Changes since v1:
- Set bMaxBurst to 15 on endpoints.
- Report more realistic speeds than 851 Mbps.
Changes since v2:
- Remove the separate SuperSpeed Plus descriptors and function
which were just a copy of the SuperSpeed descriptors and
function. Instead, just pass the SuperSpeed function to
usb_assign_descriptors for both SuperSpeed and SuperSpeed
Plus.
- Don't set bMaxBurst on the interrupt endpoint. This is
incorrect/useless and forbidden by the spec.
- Make the speed constants unsigned literals.
next reply other threads:[~2020-08-25 5:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 5:55 Lorenzo Colitti [this message]
2020-08-25 5:55 ` [PATCH v3 1/3] usb: gadget: f_ncm: fix ncm_bitrate for SuperSpeed and above Lorenzo Colitti
2020-08-25 21:16 ` Maciej Żenczykowski
2020-09-29 2:52 ` Sid Spry
2020-09-29 4:29 ` Lorenzo Colitti
2020-09-29 5:53 ` Maciej Żenczykowski
2020-08-25 5:55 ` [PATCH v3 2/3] usb: gadget: f_ncm: set SuperSpeed bulk descriptor bMaxBurst to 15 Lorenzo Colitti
2020-08-25 5:55 ` [PATCH v3 3/3] usb: gadget: f_ncm: allow using NCM in SuperSpeed Plus gadgets Lorenzo Colitti
2020-08-25 21:17 ` Maciej Żenczykowski
2020-09-09 10:40 ` [PATCH v3 0/3] usb: gadget: f_ncm: support SuperSpeed Plus, improve on SuperSpeed Greg KH
2020-09-24 7:28 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200825055505.765782-1-lorenzo@google.com \
--to=lorenzo@google.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=zenczykowski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).