From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: linux-usb@vger.kernel.org
Cc: Michael Jamet <michael.jamet@intel.com>,
Yehezkel Bernat <YehezkelShB@gmail.com>,
Andreas Noever <andreas.noever@gmail.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Gil Fine <gil.fine@intel.com>, Lukas Wunner <lukas@wunner.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: [PATCH 4/9] thunderbolt: Introduce tb_port_is_nhi()
Date: Wed, 26 Aug 2020 14:07:31 +0300 [thread overview]
Message-ID: <20200826110736.55186-5-mika.westerberg@linux.intel.com> (raw)
In-Reply-To: <20200826110736.55186-1-mika.westerberg@linux.intel.com>
This is useful if one needs to check if adapter (port) is the host
interface (NHI). Make tb_port_alloc_hopid() take advantage of this.
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---
drivers/thunderbolt/switch.c | 2 +-
drivers/thunderbolt/tb.h | 5 +++++
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/thunderbolt/switch.c b/drivers/thunderbolt/switch.c
index f646bad88309..d7164843cf8b 100644
--- a/drivers/thunderbolt/switch.c
+++ b/drivers/thunderbolt/switch.c
@@ -789,7 +789,7 @@ static int tb_port_alloc_hopid(struct tb_port *port, bool in, int min_hopid,
* NHI can use HopIDs 1-max for other adapters HopIDs 0-7 are
* reserved.
*/
- if (port->config.type != TB_TYPE_NHI && min_hopid < TB_PATH_MIN_HOPID)
+ if (!tb_port_is_nhi(port) && min_hopid < TB_PATH_MIN_HOPID)
min_hopid = TB_PATH_MIN_HOPID;
if (max_hopid < 0 || max_hopid > port_max_hopid)
diff --git a/drivers/thunderbolt/tb.h b/drivers/thunderbolt/tb.h
index a1d5de53a349..6aee18b4f53d 100644
--- a/drivers/thunderbolt/tb.h
+++ b/drivers/thunderbolt/tb.h
@@ -464,6 +464,11 @@ static inline bool tb_port_is_null(const struct tb_port *port)
return port && port->port && port->config.type == TB_TYPE_PORT;
}
+static inline bool tb_port_is_nhi(const struct tb_port *port)
+{
+ return port && port->config.type == TB_TYPE_NHI;
+}
+
static inline bool tb_port_is_pcie_down(const struct tb_port *port)
{
return port && port->config.type == TB_TYPE_PCIE_DOWN;
--
2.28.0
next prev parent reply other threads:[~2020-08-26 11:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 11:07 [PATCH 0/9] thunderbolt: Add debugfs support Mika Westerberg
2020-08-26 11:07 ` [PATCH 1/9] thunderbolt: Move struct tb_cap_any to tb_regs.h Mika Westerberg
2020-08-26 11:07 ` [PATCH 2/9] thunderbolt: Introduce tb_port_next_cap() Mika Westerberg
2020-08-26 11:07 ` [PATCH 3/9] thunderbolt: Introduce tb_switch_next_cap() Mika Westerberg
2020-09-01 9:01 ` [PATCH v2 " Mika Westerberg
2020-08-26 11:07 ` Mika Westerberg [this message]
2020-08-26 11:07 ` [PATCH 5/9] thunderbolt: Check for Intel vendor ID when identifying controller Mika Westerberg
2020-08-26 11:07 ` [PATCH 6/9] thunderbolt: Introduce tb_switch_is_ice_lake() Mika Westerberg
2020-08-26 11:07 ` [PATCH 7/9] thunderbolt: Introduce tb_switch_is_tiger_lake() Mika Westerberg
2020-08-26 11:07 ` [PATCH 8/9] thunderbolt: No need to warn in TB_CFG_ERROR_INVALID_CONFIG_SPACE Mika Westerberg
2020-08-26 11:07 ` [PATCH 9/9] thunderbolt: Add debugfs interface Mika Westerberg
2020-08-26 11:22 ` Greg Kroah-Hartman
2020-08-26 11:40 ` Mika Westerberg
2020-09-03 9:27 ` [PATCH 0/9] thunderbolt: Add debugfs support Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200826110736.55186-5-mika.westerberg@linux.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=YehezkelShB@gmail.com \
--cc=andreas.noever@gmail.com \
--cc=gil.fine@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=michael.jamet@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).