linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: linux-usb@vger.kernel.org
Cc: Michael Jamet <michael.jamet@intel.com>,
	Yehezkel Bernat <YehezkelShB@gmail.com>,
	Andreas Noever <andreas.noever@gmail.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	Gil Fine <gil.fine@intel.com>, Lukas Wunner <lukas@wunner.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: [PATCH 8/9] thunderbolt: No need to warn in TB_CFG_ERROR_INVALID_CONFIG_SPACE
Date: Wed, 26 Aug 2020 14:07:35 +0300	[thread overview]
Message-ID: <20200826110736.55186-9-mika.westerberg@linux.intel.com> (raw)
In-Reply-To: <20200826110736.55186-1-mika.westerberg@linux.intel.com>

This may be returned for example when accessing some of the vendor
specific capabilities. It is not fatal by any means so instead of WARN()
just log it as debug level. The caller gets error back anyway and is
expected to handle it accordingly.

Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---
 drivers/thunderbolt/ctl.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/thunderbolt/ctl.c b/drivers/thunderbolt/ctl.c
index f77ceae5c7d7..38e5e296fe3f 100644
--- a/drivers/thunderbolt/ctl.c
+++ b/drivers/thunderbolt/ctl.c
@@ -266,9 +266,8 @@ static void tb_cfg_print_error(struct tb_ctl *ctl,
 		 * Invalid cfg_space/offset/length combination in
 		 * cfg_read/cfg_write.
 		 */
-		tb_ctl_WARN(ctl,
-			"CFG_ERROR(%llx:%x): Invalid config space or offset\n",
-			res->response_route, res->response_port);
+		tb_ctl_dbg(ctl, "%llx:%x: invalid config space or offset\n",
+			   res->response_route, res->response_port);
 		return;
 	case TB_CFG_ERROR_NO_SUCH_PORT:
 		/*
-- 
2.28.0


  parent reply	other threads:[~2020-08-26 11:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-26 11:07 [PATCH 0/9] thunderbolt: Add debugfs support Mika Westerberg
2020-08-26 11:07 ` [PATCH 1/9] thunderbolt: Move struct tb_cap_any to tb_regs.h Mika Westerberg
2020-08-26 11:07 ` [PATCH 2/9] thunderbolt: Introduce tb_port_next_cap() Mika Westerberg
2020-08-26 11:07 ` [PATCH 3/9] thunderbolt: Introduce tb_switch_next_cap() Mika Westerberg
2020-09-01  9:01   ` [PATCH v2 " Mika Westerberg
2020-08-26 11:07 ` [PATCH 4/9] thunderbolt: Introduce tb_port_is_nhi() Mika Westerberg
2020-08-26 11:07 ` [PATCH 5/9] thunderbolt: Check for Intel vendor ID when identifying controller Mika Westerberg
2020-08-26 11:07 ` [PATCH 6/9] thunderbolt: Introduce tb_switch_is_ice_lake() Mika Westerberg
2020-08-26 11:07 ` [PATCH 7/9] thunderbolt: Introduce tb_switch_is_tiger_lake() Mika Westerberg
2020-08-26 11:07 ` Mika Westerberg [this message]
2020-08-26 11:07 ` [PATCH 9/9] thunderbolt: Add debugfs interface Mika Westerberg
2020-08-26 11:22   ` Greg Kroah-Hartman
2020-08-26 11:40     ` Mika Westerberg
2020-09-03  9:27 ` [PATCH 0/9] thunderbolt: Add debugfs support Mika Westerberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200826110736.55186-9-mika.westerberg@linux.intel.com \
    --to=mika.westerberg@linux.intel.com \
    --cc=YehezkelShB@gmail.com \
    --cc=andreas.noever@gmail.com \
    --cc=gil.fine@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=michael.jamet@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).