From: Peter Chen <peter.chen@nxp.com>
To: balbi@kernel.org
Cc: linux-usb@vger.kernel.org, linux-imx@nxp.com, pawell@cadence.com,
rogerq@ti.com, gregkh@linuxfoundation.org, jun.li@nxp.com,
Peter Chen <peter.chen@nxp.com>
Subject: [PATCH 6/8] usb: cdns3: gadget: need to handle sg case for WA2 case
Date: Tue, 1 Sep 2020 16:44:52 +0800 [thread overview]
Message-ID: <20200901084454.28649-7-peter.chen@nxp.com> (raw)
In-Reply-To: <20200901084454.28649-1-peter.chen@nxp.com>
Add sg support for WA2 case.
Signed-off-by: Peter Chen <peter.chen@nxp.com>
---
drivers/usb/cdns3/gadget.c | 44 +++++++++++++++++++++++++++-----------
1 file changed, 31 insertions(+), 13 deletions(-)
diff --git a/drivers/usb/cdns3/gadget.c b/drivers/usb/cdns3/gadget.c
index 6cb44c354f40..1fd36bc5c6db 100644
--- a/drivers/usb/cdns3/gadget.c
+++ b/drivers/usb/cdns3/gadget.c
@@ -462,6 +462,36 @@ static int cdns3_start_all_request(struct cdns3_device *priv_dev,
(reg) |= EP_STS_EN_DESCMISEN; \
} } while (0)
+static void __cdns3_descmiss_copy_data(struct usb_request *request,
+ struct usb_request *descmiss_req)
+{
+ int length = request->actual + descmiss_req->actual;
+ struct scatterlist *s = request->sg;
+
+ if (!s) {
+ if (length <= request->length) {
+ memcpy(&((u8 *)request->buf)[request->actual],
+ descmiss_req->buf,
+ descmiss_req->actual);
+ request->actual = length;
+ } else {
+ /* It should never occures */
+ request->status = -ENOMEM;
+ }
+ } else {
+ if (length <= sg_dma_len(s)) {
+ void *p = phys_to_virt(sg_dma_address(s));
+
+ memcpy(&((u8 *)p)[request->actual],
+ descmiss_req->buf,
+ descmiss_req->actual);
+ request->actual = length;
+ } else {
+ request->status = -ENOMEM;
+ }
+ }
+}
+
/**
* cdns3_wa2_descmiss_copy_data copy data from internal requests to
* request queued by class driver.
@@ -488,21 +518,9 @@ static void cdns3_wa2_descmiss_copy_data(struct cdns3_endpoint *priv_ep,
chunk_end = descmiss_priv_req->flags & REQUEST_INTERNAL_CH;
length = request->actual + descmiss_req->actual;
-
request->status = descmiss_req->status;
-
- if (length <= request->length) {
- memcpy(&((u8 *)request->buf)[request->actual],
- descmiss_req->buf,
- descmiss_req->actual);
- request->actual = length;
- } else {
- /* It should never occures */
- request->status = -ENOMEM;
- }
-
+ __cdns3_descmiss_copy_data(request, descmiss_req);
list_del_init(&descmiss_priv_req->list);
-
kfree(descmiss_req->buf);
cdns3_gadget_ep_free_request(&priv_ep->endpoint, descmiss_req);
--priv_ep->wa2_counter;
--
2.17.1
next prev parent reply other threads:[~2020-09-01 8:45 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 8:44 [PATCH 0/8] usb: cdns3: improve the sg use case Peter Chen
2020-09-01 8:44 ` [PATCH 1/8] usb: cdns3: gadget: using correct sg operations Peter Chen
2020-09-08 6:19 ` Felipe Balbi
2020-09-08 7:11 ` Peter Chen
2020-09-01 8:44 ` [PATCH 2/8] usb: cdns3: gadget: improve the dump TRB operation at cdns3_ep_run_transfer Peter Chen
2020-09-08 6:19 ` Felipe Balbi
2020-09-08 7:11 ` Peter Chen
2020-09-01 8:44 ` [PATCH 3/8] usb: cdns3: gadget: calculate TDL correctly Peter Chen
2020-09-08 6:21 ` Felipe Balbi
2020-09-08 7:15 ` Peter Chen
2020-09-01 8:44 ` [PATCH 4/8] usb: cdns3: gadget: add CHAIN and ISP bit for sg list use case Peter Chen
2020-09-08 6:22 ` Felipe Balbi
2020-09-08 7:21 ` Peter Chen
2020-09-08 7:43 ` Felipe Balbi
2020-09-01 8:44 ` [PATCH 5/8] usb: cdns3: gadget: handle sg list use case at completion correctly Peter Chen
2020-09-08 6:25 ` Felipe Balbi
2020-09-08 8:34 ` Peter Chen
2020-09-10 8:37 ` Peter Chen
2020-09-01 8:44 ` Peter Chen [this message]
2020-09-08 6:29 ` [PATCH 6/8] usb: cdns3: gadget: need to handle sg case for WA2 case Felipe Balbi
2020-09-08 9:07 ` Peter Chen
2020-09-01 8:44 ` [PATCH 7/8] usb: cdns3: gadget: sg_support is only for DEV_VER_V2 or above Peter Chen
2020-09-08 6:30 ` Felipe Balbi
2020-09-08 9:08 ` Peter Chen
2020-09-01 8:44 ` [PATCH 8/8] usb: cdns3: gadget: enlarge the TRB ring length Peter Chen
2020-09-08 6:32 ` Felipe Balbi
2020-09-08 9:18 ` Peter Chen
2020-09-08 9:30 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200901084454.28649-7-peter.chen@nxp.com \
--to=peter.chen@nxp.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jun.li@nxp.com \
--cc=linux-imx@nxp.com \
--cc=linux-usb@vger.kernel.org \
--cc=pawell@cadence.com \
--cc=rogerq@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).