* Re: copy/paste error in unusual_uas.h from commit bc3bdb1
2020-09-02 5:14 copy/paste error in unusual_uas.h from commit bc3bdb1 Jean-Francois Pirus
@ 2020-09-02 5:28 ` Greg KH
2020-09-02 14:38 ` Alan Stern
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2020-09-02 5:28 UTC (permalink / raw)
To: Jean-Francois Pirus; +Cc: Alan Stern, usb-storage, linux-usb
On Wed, Sep 02, 2020 at 05:14:12PM +1200, Jean-Francois Pirus wrote:
> Looks like a copy/paste error from the previous entry.
>
> patch:
>
> --- unusual_uas.h.org 2020-09-02 17:00:32.295919812 +1200
> +++ unusual_uas.h 2020-09-02 17:01:02.596173298 +1200
> @@ -69,7 +69,7 @@
> /* Reported-by: David Kozub <zub@linux.fjfi.cvut.cz> */
> UNUSUAL_DEV(0x152d, 0x0578, 0x0000, 0x9999,
> "JMicron",
> - "JMS567",
> + "JMS578",
> USB_SC_DEVICE, USB_PR_DEVICE, NULL,
> US_FL_BROKEN_FUA),
>
> Thanks.
>
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- Your patch does not have a Signed-off-by: line. Please read the
kernel file, Documentation/SubmittingPatches and resend it after
adding that line. Note, the line needs to be in the body of the
email, before the patch, not at the bottom of the patch or in the
email signature.
- Your patch was sent privately to Greg. Kernel development is done in
public, please always cc: a public mailing list with a patch
submission. Using the tool, scripts/get_maintainer.pl on the patch
will tell you what mailing list to cc.
- You did not specify a description of why the patch is needed, or
possibly, any description at all, in the email body. Please read the
section entitled "The canonical patch format" in the kernel file,
Documentation/SubmittingPatches for what is needed in order to
properly describe the change.
- You did not write a descriptive Subject: for the patch, allowing Greg,
and everyone else, to know what this patch is all about. Please read
the section entitled "The canonical patch format" in the kernel file,
Documentation/SubmittingPatches for what a proper Subject: line should
look like.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: copy/paste error in unusual_uas.h from commit bc3bdb1
2020-09-02 5:14 copy/paste error in unusual_uas.h from commit bc3bdb1 Jean-Francois Pirus
2020-09-02 5:28 ` Greg KH
@ 2020-09-02 14:38 ` Alan Stern
1 sibling, 0 replies; 3+ messages in thread
From: Alan Stern @ 2020-09-02 14:38 UTC (permalink / raw)
To: Jean-Francois Pirus; +Cc: usb-storage, linux-usb
On Wed, Sep 02, 2020 at 05:14:12PM +1200, Jean-Francois Pirus wrote:
> Looks like a copy/paste error from the previous entry.
It may look like a copy-paste error, but it isn't. You can tell if you
go back and read the emails that led up to this commit.
> patch:
>
> --- unusual_uas.h.org 2020-09-02 17:00:32.295919812 +1200
> +++ unusual_uas.h 2020-09-02 17:01:02.596173298 +1200
> @@ -69,7 +69,7 @@
> /* Reported-by: David Kozub <zub@linux.fjfi.cvut.cz> */
> UNUSUAL_DEV(0x152d, 0x0578, 0x0000, 0x9999,
> "JMicron",
> - "JMS567",
> + "JMS578",
> USB_SC_DEVICE, USB_PR_DEVICE, NULL,
> US_FL_BROKEN_FUA),
The same entry is present in unusual_devs.h (as you would see if you had
read the original commit). How come you didn't change that one as well?
Alan Stern
^ permalink raw reply [flat|nested] 3+ messages in thread