From: Matthias Kaehlcke <mka@chromium.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org,
Ravi Chandra Sadineni <ravisadineni@chromium.org>,
Douglas Anderson <dianders@chromium.org>,
Bastien Nocera <hadess@hadess.net>,
Krzysztof Kozlowski <krzk@kernel.org>,
Stephen Boyd <swboyd@chromium.org>,
linux-usb@vger.kernel.org, Alan Stern <stern@rowland.harvard.edu>,
"Alexander A. Klimov" <grandmaster@al2klimov.de>,
Masahiro Yamada <masahiroy@kernel.org>
Subject: Re: [RFC PATCH] USB: misc: Add usb_hub_pwr driver
Date: Wed, 2 Sep 2020 11:07:43 -0700 [thread overview]
Message-ID: <20200902180743.GF3419728@google.com> (raw)
In-Reply-To: <20200902060744.GA142357@kroah.com>
Hi Greg,
On Wed, Sep 02, 2020 at 08:07:44AM +0200, Greg Kroah-Hartman wrote:
> On Tue, Sep 01, 2020 at 01:21:43PM -0700, Matthias Kaehlcke wrote:
> > diff --git a/drivers/usb/misc/Makefile b/drivers/usb/misc/Makefile
> > index da39bddb0604..2bd02388ca62 100644
> > --- a/drivers/usb/misc/Makefile
> > +++ b/drivers/usb/misc/Makefile
> > @@ -31,3 +31,4 @@ obj-$(CONFIG_USB_CHAOSKEY) += chaoskey.o
> >
> > obj-$(CONFIG_USB_SISUSBVGA) += sisusbvga/
> > obj-$(CONFIG_USB_LINK_LAYER_TEST) += lvstest.o
> > +obj-$(CONFIG_USB_HUB_PWR) += usb_hub_pwr.o usb_hub_psupply.o
>
> Why is this 2 files? Why can't it just be one?
It's effectively two drivers that work together, it seemed cleaner to me
to have a file for every driver.
The 'usb_hub_psupply' driver (which probably should be named
'onboard_usb_hub' or similar) would even be useful on its own (taking
care of powering the hub on and potentially other setup actions)
with a bit of rework.
> And isn't this much the same thing as many of the other "misc" hub
> controller drivers we have?
There are some commonalities, however most of these drivers seem to
target USB hubs with an I2C bus, using custom 'commands' for initialization
and putting the hub in/out of standby.
The drivers in this patch have two goals:
- provide a generic (configurable) solution for powering up/initializing
a USB hub
- enable support for powering down a USB hub during system suspend
> And to make it easier to review, can you split out the device tree
> descriptions so that the DT maintainers can review that?
Sure, I wasn't sure if this is the right approach, hence I only sent
an RFC without formal bindings to get initial feedback. As of now it
seems that you are at least not frontally opposed it ;-)
prev parent reply other threads:[~2020-09-02 18:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 20:21 [RFC PATCH] USB: misc: Add usb_hub_pwr driver Matthias Kaehlcke
2020-09-01 21:21 ` Doug Anderson
2020-09-02 0:01 ` Matthias Kaehlcke
2020-09-02 5:31 ` Peter Chen
2020-09-02 17:45 ` Matthias Kaehlcke
2020-09-03 1:46 ` Peter Chen
2020-09-14 18:42 ` Matthias Kaehlcke
2020-09-02 6:07 ` Greg Kroah-Hartman
2020-09-02 18:07 ` Matthias Kaehlcke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200902180743.GF3419728@google.com \
--to=mka@chromium.org \
--cc=dianders@chromium.org \
--cc=grandmaster@al2klimov.de \
--cc=gregkh@linuxfoundation.org \
--cc=hadess@hadess.net \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=ravisadineni@chromium.org \
--cc=stern@rowland.harvard.edu \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).