Linux USB
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas@wunner.de>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: linux-usb@vger.kernel.org,
	Michael Jamet <michael.jamet@intel.com>,
	Yehezkel Bernat <YehezkelShB@gmail.com>,
	Andreas Noever <andreas.noever@gmail.com>,
	Kai-Heng Feng <kai.heng.feng@canonical.com>
Subject: Re: [PATCH] thunderbolt: Retry DROM read once if parsing fails
Date: Mon, 7 Sep 2020 13:21:51 +0200	[thread overview]
Message-ID: <20200907112151.GA22115@wunner.de> (raw)
In-Reply-To: <20200907110340.71031-1-mika.westerberg@linux.intel.com>

On Mon, Sep 07, 2020 at 02:03:40PM +0300, Mika Westerberg wrote:
> Kai-Heng reported that sometimes DROM parsing of ASUS PA27AC Thunderbolt 3
> monitor fails. This makes the driver to fail to add the device so only
> DisplayPort tunneling is functional.

Maybe the DROM is contained in an external EEPROM attached via slow
SPI or i2c and cannot be read in time before a response on the control
channel is due?  Does it help to always delay 100 ms before performing
the DROM read with this display?  Perhaps a quirk specific for this
display is more appropriate than a change which affects all devices?
Because this way of working around problems is difficult to maintain
long term.

Thanks,

Lukas

  reply	other threads:[~2020-09-07 11:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-07 11:03 [PATCH] thunderbolt: Retry DROM read once if parsing fails Mika Westerberg
2020-09-07 11:21 ` Lukas Wunner [this message]
2020-09-07 12:02   ` Mika Westerberg
2020-09-09 11:06 ` Mika Westerberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200907112151.GA22115@wunner.de \
    --to=lukas@wunner.de \
    --cc=YehezkelShB@gmail.com \
    --cc=andreas.noever@gmail.com \
    --cc=kai.heng.feng@canonical.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=michael.jamet@intel.com \
    --cc=mika.westerberg@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox