linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniele Palmas <dnlplm@gmail.com>
To: "Bjørn Mork" <bjorn@mork.no>
Cc: Kristian Evensen <kristian.evensen@gmail.com>,
	Paul Gildea <paul.gildea@gmail.com>,
	Carl Yin <carl.yin@quectel.com>,
	"David S . Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	netdev@vger.kernel.org, linux-usb@vger.kernel.org,
	Daniele Palmas <dnlplm@gmail.com>
Subject: [PATCH net-next 1/1] net: usb: qmi_wwan: add default rx_urb_size
Date: Wed,  9 Sep 2020 11:13:02 +0200	[thread overview]
Message-ID: <20200909091302.20992-1-dnlplm@gmail.com> (raw)

Add default rx_urb_size to support QMAP download data aggregation
without needing additional setup steps in userspace.

The value chosen is the current highest one seen in available modems.

The patch has the side-effect of fixing a babble issue in raw-ip mode
reported by multiple users.

Signed-off-by: Daniele Palmas <dnlplm@gmail.com>
---
Resending with mailing lists added: sorry for the noise.

Hi Bjørn and all,

this patch tries to address the issue reported in the following threads

https://www.spinics.net/lists/netdev/msg635944.html
https://www.spinics.net/lists/linux-usb/msg198846.html
https://www.spinics.net/lists/linux-usb/msg198025.html

so I'm adding the people involved, maybe you can give it a try to
double check if this is good for you.

On my side, I performed tests with different QC chipsets without
experiencing problems.

Thanks,
Daniele
---
 drivers/net/usb/qmi_wwan.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
index 07c42c0719f5..92d568f982b6 100644
--- a/drivers/net/usb/qmi_wwan.c
+++ b/drivers/net/usb/qmi_wwan.c
@@ -815,6 +815,10 @@ static int qmi_wwan_bind(struct usbnet *dev, struct usb_interface *intf)
 	}
 	dev->net->netdev_ops = &qmi_wwan_netdev_ops;
 	dev->net->sysfs_groups[0] = &qmi_wwan_sysfs_attr_group;
+
+	/* Set rx_urb_size to allow QMAP rx data aggregation */
+	dev->rx_urb_size = 32768;
+
 err:
 	return status;
 }
-- 
2.17.1


             reply	other threads:[~2020-09-09  9:14 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-09  9:13 Daniele Palmas [this message]
2020-09-09 11:09 ` 答复: [PATCH net-next 1/1] net: usb: qmi_wwan: add default rx_urb_size Carl Yin(殷张成)
2020-09-09 11:57   ` Daniele Palmas
2020-09-09 12:49     ` Bjørn Mork
2020-09-09 21:10       ` Daniele Palmas
2020-09-09 12:28 ` Greg KH
2020-09-09 20:50   ` Daniele Palmas
2020-11-04 17:01 ` Kristian Evensen
2020-11-12 18:28   ` Daniele Palmas
2020-11-13  7:37     ` Kristian Evensen
2020-11-13  8:37       ` 答复: " Carl Yin(殷张成)
2020-11-13  8:50         ` Kristian Evensen
2020-11-13 15:04           ` Kristian Evensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200909091302.20992-1-dnlplm@gmail.com \
    --to=dnlplm@gmail.com \
    --cc=bjorn@mork.no \
    --cc=carl.yin@quectel.com \
    --cc=davem@davemloft.net \
    --cc=kristian.evensen@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=paul.gildea@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).