From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA4CFC43461 for ; Wed, 9 Sep 2020 10:24:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 976AE21D7F for ; Wed, 9 Sep 2020 10:24:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726399AbgIIKYA (ORCPT ); Wed, 9 Sep 2020 06:24:00 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:34906 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725877AbgIIKXt (ORCPT ); Wed, 9 Sep 2020 06:23:49 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 95BAC1C0B87; Wed, 9 Sep 2020 12:23:46 +0200 (CEST) Date: Wed, 9 Sep 2020 12:23:45 +0200 From: Pavel Machek To: Felipe Balbi Cc: Paul Cercueil , =?utf-8?B?5ZGo55Cw5p2w?= , =?utf-8?B?5ZGo5q2j?= , =?utf-8?B?5ryG6bmP5oyv?= , od@zcrc.me, Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] USB: PHY: JZ4770: Fix uninitialized value written to HW register Message-ID: <20200909102345.GA9222@amd> References: <20200827124308.71963-1-paul@crapouillou.net> <20200827124308.71963-2-paul@crapouillou.net> <87v9h4i6t5.fsf@kernel.org> <87bliwi5kx.fsf@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="YiEDa0DAkWCtVeE4" Content-Disposition: inline In-Reply-To: <87bliwi5kx.fsf@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org --YiEDa0DAkWCtVeE4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > >>> - reg =3D USBPCR_IDPULLUP_OTG | USBPCR_VBUSVLDEXT=20 > >>> | USBPCR_TXPREEMPHTUNE | > >>> + return USBPCR_IDPULLUP_OTG | USBPCR_VBUSVLDEXT |=20 > >>> USBPCR_TXPREEMPHTUNE | > >>> USBPCR_COMMONONN | USBPCR_POR; > >>> - writel(reg, priv->base + REG_USBPCR_OFFSET); > >>=20 > >> not a bug fix > > > > Well, if you don't like my bug fix, next time wait for my Reviewed-by. >=20 > why so angry? Take a break every once in a while. Besides, someone else > already sent the oneliner before you ;-) Your behaviour is pretty good explanation for angry people on the mailing list. Best regards, Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --YiEDa0DAkWCtVeE4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAl9YrTEACgkQMOfwapXb+vJ8tACgjD/mpcjYY3DfFtCvIm+G/xF4 z9oAoIKgzqrArYXBGniQrGbo/5qKu8n5 =hxC1 -----END PGP SIGNATURE----- --YiEDa0DAkWCtVeE4--