From: Greg KH <gregkh@linuxfoundation.org>
To: Ajay Gupta <ajaykuee@gmail.com>
Cc: heikki.krogerus@linux.intel.com, linux-usb@vger.kernel.org,
Ajay Gupta <ajayg@nvidia.com>
Subject: Re: [PATCH] usb: typec: ucsi_ccg: use dev_info for timeout error
Date: Mon, 21 Sep 2020 20:54:32 +0200 [thread overview]
Message-ID: <20200921185432.GA1484407@kroah.com> (raw)
In-Reply-To: <20200921174216.2862-1-ajayg@nvidia.com>
On Mon, Sep 21, 2020 at 10:42:16AM -0700, Ajay Gupta wrote:
> From: Ajay Gupta <ajayg@nvidia.com>
>
> Timeout error may be seen due to missing USB Type-C UCSI controller
> on some NVIDIA GPU card. Currently we don't have a correct way to
> identify these cards.
No unique id anywhere??? That feels like someone really messed up :(
>
> Tools like Plymouth (splashscreen) doesn't like dev_err so
> changing timeout status log to dev_info.
>
> Bug information:
> https://bugzilla.kernel.org/show_bug.cgi?id=206653
>
> Signed-off-by: Ajay Gupta <ajayg@nvidia.com>
> ---
> drivers/usb/typec/ucsi/ucsi_ccg.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/typec/ucsi/ucsi_ccg.c b/drivers/usb/typec/ucsi/ucsi_ccg.c
> index bff96d64dddf..d69432df866e 100644
> --- a/drivers/usb/typec/ucsi/ucsi_ccg.c
> +++ b/drivers/usb/typec/ucsi/ucsi_ccg.c
> @@ -252,7 +252,7 @@ static int ccg_read(struct ucsi_ccg *uc, u16 rab, u8 *data, u32 len)
> put_unaligned_le16(rab, buf);
> status = i2c_transfer(client->adapter, msgs, ARRAY_SIZE(msgs));
> if (status < 0) {
> - dev_err(uc->dev, "i2c_transfer failed %d\n", status);
> + dev_info(uc->dev, "i2c_transfer failed %d\n", status);
It's an error, leave it an error.
If it's not an error, don't log it.
Or better yet, fix the hardware :)
thanks,
greg k-h
next prev parent reply other threads:[~2020-09-21 18:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-21 17:42 [PATCH] usb: typec: ucsi_ccg: use dev_info for timeout error Ajay Gupta
2020-09-21 18:54 ` Greg KH [this message]
2020-09-21 20:50 ` Ajay Gupta
2020-09-22 5:43 ` Greg KH
2020-09-22 23:24 ` Ajay Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200921185432.GA1484407@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=ajayg@nvidia.com \
--cc=ajaykuee@gmail.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).