linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregKH@linuxfoundation.org>
To: Oliver Neukum <oneukum@suse.com>
Cc: himadrispandya@gmail.com, stern@rowland.harvard.edu,
	linux-usb@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>
Subject: Re: [RFC 09/14] sound: usx2y: move to use usb_control_msg_send()
Date: Fri, 25 Sep 2020 16:32:27 +0200	[thread overview]
Message-ID: <20200925143227.GA3083738@kroah.com> (raw)
In-Reply-To: <20200923134348.23862-10-oneukum@suse.com>

On Wed, Sep 23, 2020 at 03:43:43PM +0200, Oliver Neukum wrote:
> From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> The usb_control_msg_send() call can handle data on the stack, as well as
> returning an error if a "short" write happens, so move the driver over
> to using that call instead.  This ends up removing a helper function
> that is no longer needed.
> 
> v2: API change in usb_control_msg_send()
> 
> Cc: Jaroslav Kysela <perex@perex.cz>
> Reviewed-by: Takashi Iwai <tiwai@suse.de>
> Link: https://lore.kernel.org/r/20200914153756.3412156-7-gregkh@linuxfoundation.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
>  sound/usb/usx2y/us122l.c | 44 +++++++++-----------------------------------
>  1 file changed, 9 insertions(+), 35 deletions(-)
> 
> diff --git a/sound/usb/usx2y/us122l.c b/sound/usb/usx2y/us122l.c
> index f86f7a61fb36..3614e6802dc1 100644
> --- a/sound/usb/usx2y/us122l.c
> +++ b/sound/usb/usx2y/us122l.c
> @@ -1,4 +1,4 @@
> -// SPDX-License-Identifier: GPL-2.0-or-later
> +// SPDX-License-Identifier: GPL-2.0-or-late

Odd, my original patch did not change this line :)

I'll go drop this from the patch...

thanks,

greg k-h

  reply	other threads:[~2020-09-25 14:32 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-23 13:43 [RFC] change the new message to provide for memory allocations Oliver Neukum
2020-09-23 13:43 ` [RFC 01/14] Revert "USB: core: hub.c: use usb_control_msg_send() in a few places" Oliver Neukum
2020-09-23 13:43 ` [RFC 02/14] Revert "Bluetooth: ath3k: use usb_control_msg_send() and usb_control_msg_recv()" Oliver Neukum
2020-09-23 13:43 ` [RFC 03/14] Revert "sound: hiface: move to use usb_control_msg_send()" Oliver Neukum
2020-09-23 13:43 ` [RFC 04/14] Revert "sound: line6: move to use usb_control_msg_send() and usb_control_msg_recv()" Oliver Neukum
2020-09-23 13:43 ` [RFC 05/14] Revert "sound: 6fire: " Oliver Neukum
2020-09-23 13:43 ` [RFC 06/14] Revert "sound: usx2y: move to use usb_control_msg_send()" Oliver Neukum
2020-09-23 13:43 ` [RFC 07/14] Revert "USB: legousbtower: use usb_control_msg_recv()" Oliver Neukum
2020-09-23 13:43 ` [RFC 08/14] USB: correct API of usb_control_msg_send/recv Oliver Neukum
2020-09-25  9:31   ` [PATCH 0/2] [usb] Petko Manolov
2020-09-25  9:31     ` [PATCH 1/2] net: pegasus: convert control messages to the new send/recv scheme Petko Manolov
2020-09-25 14:37       ` Greg KH
2020-09-25 16:01         ` [PATCH 0/2] [patch v2] utilize the new control message send and receive API Petko Manolov
2020-09-25 16:01           ` [PATCH 1/2] net: pegasus: convert control messages to the new send/recv scheme Petko Manolov
2020-09-26  5:44             ` Greg KH
2020-09-26  8:21               ` Petko Manolov
2020-09-26 12:45                 ` Greg KH
2020-09-25 16:02           ` [PATCH 2/2] net: rtl8150: " Petko Manolov
2020-09-25 20:14             ` kernel test robot
2020-09-25 16:05         ` [PATCH 1/2] net: pegasus: " Petko Manolov
2020-09-26  5:45           ` Greg KH
2020-09-25  9:31     ` [PATCH 2/2] net: rtl8150: " Petko Manolov
2020-09-25 14:37       ` Greg KH
2020-09-26  9:13   ` [PATCH v3 0/2] Use the new usb control message API Petko Manolov
2020-09-26  9:13     ` [PATCH v3 1/2] net: pegasus: " Petko Manolov
2020-09-26  9:13     ` [PATCH v3 2/2] net: rtl8150: " Petko Manolov
2020-09-27 10:16     ` [PATCH v3 0/2] " Greg KH
2020-09-27 12:56       ` Petko Manolov
2020-09-27 12:49   ` [PATCH RESEND " Petko Manolov
2020-09-27 12:49     ` [PATCH RESEND v3 1/2] net: pegasus: " Petko Manolov
2020-09-27 12:49     ` [PATCH RESEND v3 2/2] net: rtl8150: " Petko Manolov
2020-09-28 23:00     ` [PATCH RESEND v3 0/2] " David Miller
2020-09-29  4:59       ` Petko Manolov
2020-09-29 19:58         ` David Miller
2020-09-30  6:23           ` Greg KH
2020-09-23 13:43 ` [RFC 09/14] sound: usx2y: move to use usb_control_msg_send() Oliver Neukum
2020-09-25 14:32   ` Greg KH [this message]
2020-09-23 13:43 ` [RFC 10/14] sound: 6fire: move to use usb_control_msg_send() and usb_control_msg_recv() Oliver Neukum
2020-09-23 13:43 ` [RFC 11/14] USB: legousbtower: use usb_control_msg_recv() Oliver Neukum
2020-09-23 13:43 ` [RFC 12/14] sound: line6: move to use usb_control_msg_send() and usb_control_msg_recv() Oliver Neukum
2020-09-23 13:43 ` [RFC 13/14] sound: hiface: move to use usb_control_msg_send() Oliver Neukum
2020-09-23 13:43 ` [RFC 14/14] Bluetooth: ath3k: use usb_control_msg_send() and usb_control_msg_recv() Oliver Neukum
2020-09-23 17:21 ` [RFC] change the new message to provide for memory allocations Greg KH
2020-09-23 17:32   ` Oliver Neukum
2020-09-23 17:46     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200925143227.GA3083738@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=himadrispandya@gmail.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=oneukum@suse.com \
    --cc=perex@perex.cz \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).