From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3ECBFC4727C for ; Fri, 25 Sep 2020 14:53:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F2EA42311D for ; Fri, 25 Sep 2020 14:53:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601045621; bh=omjfsEO+c6LHE572NzhOO83hYXo/68rhiLLBf82htqk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=rcoIM/Bv9Goq0T3iCrQrviZLoF67wjpc1g5kyR1F4JyZ0S8G2uLzCYIXRpVzvX7dS 6F0Vqa1uJsAjKJfCuEBG/0SoYcKTW3W8BUWeJsAG3XFX9FMSWkIXg1+KBWXR5jOyrM EdXk/26eXAuONwqhtVKvWN+4IiFr/DhyY/iRaRsM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729028AbgIYOxk (ORCPT ); Fri, 25 Sep 2020 10:53:40 -0400 Received: from mail-lf1-f67.google.com ([209.85.167.67]:33867 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727749AbgIYOxj (ORCPT ); Fri, 25 Sep 2020 10:53:39 -0400 Received: by mail-lf1-f67.google.com with SMTP id u8so3147312lff.1; Fri, 25 Sep 2020 07:53:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8BoxUeVizmKKAcaUi8Yfb1uh4zDY+60H994gLNpA+fw=; b=IQGncygq8g50OwobV8mkm8fAIF7/ll3n9TTxHnzr5GGrzvWV6xS/pa/M4eCj9ljOoS T3Ug4ist4W8WpRjbTLsKEM8k1WG2u7ZUTOcfdCIUw2mzSVrtiNKn1K2r+Tavn4P32F+j 8/KtGjVdmGKb/d2hPG4mQucW4dAiw9Sgk8MRrHPZM6Ue48DNP2N+pn/TS/1pILr8TWZ7 XTEl151eNdPnifcOw/rxqaBehWXJS1OGVdornG1RY1CtBTPaOE/eTPtZPKjP+81Ziy3Z SpJbimM4GuP+I4JcB+SJVCeOSWdArDGCxHwtEGovYm4sdqQe2g+eEHWM3L291Puzs9Md B0xQ== X-Gm-Message-State: AOAM530OznCHTZxwvKABZ8oeQ1Y5wYiS49F55ZyRodgkmuny3oof/929 IykrVkYYCzdyoSTxPNJ7KbZS3AOYqlo= X-Google-Smtp-Source: ABdhPJyg+NvzLlKqClkaVwuYwH/4wfM3vQ1nlz0aaBEntmegb0lhchoSCA6o1TXM/djzwD/9gaYMJw== X-Received: by 2002:ac2:4c31:: with SMTP id u17mr1426191lfq.1.1601045618089; Fri, 25 Sep 2020 07:53:38 -0700 (PDT) Received: from xi.terra (c-beaee455.07-184-6d6c6d4.bbcust.telenor.se. [85.228.174.190]) by smtp.gmail.com with ESMTPSA id d24sm2457068lfn.140.2020.09.25.07.53.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Sep 2020 07:53:37 -0700 (PDT) Received: from johan by xi.terra with local (Exim 4.93.0.4) (envelope-from ) id 1kLp6J-0003kn-7A; Fri, 25 Sep 2020 16:53:31 +0200 Date: Fri, 25 Sep 2020 16:53:31 +0200 From: Johan Hovold To: Greg Kroah-Hartman Cc: Johan Hovold , Oliver Neukum , linux-usb@vger.kernel.org, Daniel Caujolle-Bert , stable@vger.kernel.org Subject: Re: [PATCH v2] USB: cdc-acm: add Whistler radio scanners TRX series support Message-ID: <20200925145331.GL24441@localhost> References: <20200921081022.6881-1-johan@kernel.org> <20200925144922.GA3113925@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200925144922.GA3113925@kroah.com> Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Fri, Sep 25, 2020 at 04:49:22PM +0200, Greg Kroah-Hartman wrote: > On Mon, Sep 21, 2020 at 10:10:22AM +0200, Johan Hovold wrote: > > Add support for Whistler radio scanners TRX series, which have a union > > descriptor that designates a mass-storage interface as master. Handle > > that by generalising the NO_DATA_INTERFACE quirk to allow us to fall > > back to using the combined-interface detection. > > > > Note that the NO_DATA_INTERFACE quirk was added by commit fd5054c169d2 > > ("USB: cdc_acm: Fix oops when Droids MuIn LCD is connected") to handle a > > combined-interface-type device with a broken call-management descriptor > > by hardcoding the "data" interface number. > > > > Link: https://lore.kernel.org/r/5f4ca4f8.1c69fb81.a4487.0f5f@mx.google.com > > Reported-by: Daniel Caujolle-Bert > > Tested-by: Daniel Caujolle-Bert > > Cc: stable@vger.kernel.org > > Signed-off-by: Johan Hovold > > --- > > > > v2 > > - use the right class define in the device-id table (not subclass with > > same value) > > Is this independant of your other patch series for cdc-acm? This one is superseded by the series, so please drop this patch. Sorry for not making that clear. Johan