From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75BE9C41604 for ; Wed, 7 Oct 2020 14:58:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2A66C212CC for ; Wed, 7 Oct 2020 14:58:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728741AbgJGO6M (ORCPT ); Wed, 7 Oct 2020 10:58:12 -0400 Received: from netrider.rowland.org ([192.131.102.5]:56751 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1728637AbgJGO6K (ORCPT ); Wed, 7 Oct 2020 10:58:10 -0400 Received: (qmail 456826 invoked by uid 1000); 7 Oct 2020 10:58:09 -0400 Date: Wed, 7 Oct 2020 10:58:09 -0400 From: Alan Stern To: Joel Stanley Cc: Ryan Chen , Andrew Jeffery , Linux ARM , linux-aspeed , Linux Kernel Mailing List , linux-usb@vger.kernel.org, bmc-sw@aspeedtech.com Subject: Re: [PATCH 2/3] usb: host: add uhci compatible support for ast2600-uhci Message-ID: <20201007145809.GA456169@rowland.harvard.edu> References: <20200930040823.26065-1-ryan_chen@aspeedtech.com> <20200930040823.26065-3-ryan_chen@aspeedtech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Wed, Oct 07, 2020 at 11:25:04AM +0000, Joel Stanley wrote: > On Wed, 30 Sep 2020 at 04:08, Ryan Chen wrote: > > > > Add support for AST2600 SOC UHCI driver. > > > > Signed-off-by: Ryan Chen > > Reviewed-by: Joel Stanley > > USB maintainers, can you please take this patch (2/3)? I will take the > others in this series through the aspeed tree. > > Cheers, > > Joel > > > > --- > > drivers/usb/host/uhci-platform.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/usb/host/uhci-platform.c b/drivers/usb/host/uhci-platform.c > > index 70dbd95c3f06..fa40fe125c2a 100644 > > --- a/drivers/usb/host/uhci-platform.c > > +++ b/drivers/usb/host/uhci-platform.c > > @@ -113,7 +113,8 @@ static int uhci_hcd_platform_probe(struct platform_device *pdev) > > num_ports); > > } > > if (of_device_is_compatible(np, "aspeed,ast2400-uhci") || > > - of_device_is_compatible(np, "aspeed,ast2500-uhci")) { > > + of_device_is_compatible(np, "aspeed,ast2500-uhci") || > > + of_device_is_compatible(np, "aspeed,ast2600-uhci")) { > > uhci->is_aspeed = 1; > > dev_info(&pdev->dev, > > "Enabled Aspeed implementation workarounds\n"); > > -- > > 2.17.1 > > The indentation of the continuation lines isn't good, because the continued parts are aligned with the lines in the conditional block. They should be visually distinct. Either align with the "of_device..." at the start or indent by two extra tab stops. Once this is fixed, you can add: Acked-by: Alan Stern Alan Stern