From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CE19C433DF for ; Tue, 13 Oct 2020 06:36:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EEA4B208D5 for ; Tue, 13 Oct 2020 06:36:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602570964; bh=OzYDo5bge4BHECOk5mX0aFz05bzK8pdkGElBQ1KpmNs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=SCSbYg0wPwqSyb1cpgq7LxWsJww4/QyfavLDlJ1KzzokMM1/OmhZczVaOsItkLFbF UNAY9K/4594NpC8aoW/o8FvYeUvR2JHses3UPAekepeTOcof9TwTg0RcSL65SttdjV i8xWqB6uK+Kul2bisnEyB5EPGY6xXMGCL7uBXNp8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389441AbgJMGf7 (ORCPT ); Tue, 13 Oct 2020 02:35:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:40300 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389353AbgJMGf7 (ORCPT ); Tue, 13 Oct 2020 02:35:59 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2E52B208D5; Tue, 13 Oct 2020 06:35:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602570958; bh=OzYDo5bge4BHECOk5mX0aFz05bzK8pdkGElBQ1KpmNs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=L7xRjYu9OMo8UhZ4EV4S6Y5fTrGlKZl3lraCMK5dVN1BJVxsLW8qiwPwuCx9aPkeU Yc6OcdLtenHmToCHgEaVlh5KNxIOObFt7ac5Mq+yilUxfh3VPUNupmMWXN1bNk2ZtR FmET11Lu7NScF3xybyZcem/crqgcZ3ZpRDiNlFbo= Date: Tue, 13 Oct 2020 08:36:36 +0200 From: Greg Kroah-Hartman To: Lukas Bulwahn Cc: Alan Stern , Sudip Mukherjee , linux-kernel@vger.kernel.org, linux-safety@lists.elisa.tech, linux-usb@vger.kernel.org Subject: Re: [linux-safety] [PATCH] usb: host: ehci-sched: add comment about find_tt() not returning error Message-ID: <20201013063636.GA1663576@kroah.com> References: <20201011205008.24369-1-sudipm.mukherjee@gmail.com> <20201012145710.GA631710@rowland.harvard.edu> <20201012151816.GA1559916@kroah.com> <20201013052317.GB330398@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Tue, Oct 13, 2020 at 07:37:34AM +0200, Lukas Bulwahn wrote: > > > On Tue, 13 Oct 2020, Greg Kroah-Hartman wrote: > > > On Mon, Oct 12, 2020 at 08:25:30PM +0200, Lukas Bulwahn wrote: > > > > > > > > > On Mon, 12 Oct 2020, Greg Kroah-Hartman wrote: > > > > > > > On Mon, Oct 12, 2020 at 05:10:21PM +0200, Lukas Bulwahn wrote: > > > > > And for the static analysis finding, we need to find a way to ignore this > > > > > finding without simply ignoring all findings or new findings that just > > > > > look very similar to the original finding, but which are valid. > > > > > > > > Then I suggest you fix the tool that "flagged" this, surely this is not > > > > the only thing it detected with a test like this, right? > > > > > > > > What tool reported this? > > > > > > > > > > Sudip and I are following on clang analyzer findings. > > > > > > On linux-next, there is new build target 'make clang-analyzer' that > > > outputs a bunch of warnings, just as you would expect from such static > > > analysis tools. > > > > Why not fix the things that it finds that are actually issues? If there > > are no actual issues found, then perhaps you should use a better tool? :) > > > > Completely agree. That is why I was against adding comments here and > elsewhere just to have the "good feeling of doing something" after the > tool reported a warning and we spend some time understanding the code to > conclude that we now understand the code better than the tool. > > If you know a better tool, we will use it :) unfortunately, there is no > easy way of finding out that a tool just reports false positives and not a > single true positive among 1000 reports... Who is "forcing" you to use any tool? What is your goal here? greg k-h