From: Johan Hovold <johan@kernel.org>
To: Sasha Levin <sashal@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Johan Hovold <johan@kernel.org>,
Daniel Caujolle-Bert <f1rmb.daniel@gmail.com>,
Oliver Neukum <oneukum@suse.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org
Subject: Re: [PATCH AUTOSEL 5.9 054/111] USB: cdc-acm: handle broken union descriptors
Date: Mon, 19 Oct 2020 09:02:18 +0200 [thread overview]
Message-ID: <20201019070218.GO26280@localhost> (raw)
In-Reply-To: <20201018191807.4052726-54-sashal@kernel.org>
On Sun, Oct 18, 2020 at 03:17:10PM -0400, Sasha Levin wrote:
> From: Johan Hovold <johan@kernel.org>
>
> [ Upstream commit 960c7339de27c6d6fec13b54880501c3576bb08d ]
>
> Handle broken union functional descriptors where the master-interface
> doesn't exist or where its class is of neither Communication or Data
> type (as required by the specification) by falling back to
> "combined-interface" probing.
>
> Note that this still allows for handling union descriptors with switched
> interfaces.
>
> This specifically makes the Whistler radio scanners TRX series devices
> work with the driver without adding further quirks to the device-id
> table.
>
> Reported-by: Daniel Caujolle-Bert <f1rmb.daniel@gmail.com>
> Tested-by: Daniel Caujolle-Bert <f1rmb.daniel@gmail.com>
> Acked-by: Oliver Neukum <oneukum@suse.com>
> Signed-off-by: Johan Hovold <johan@kernel.org>
> Link: https://lore.kernel.org/r/20200921135951.24045-3-johan@kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Sasha Levin <sashal@kernel.org>
I was surprised to see this picked up by AUTOSEL since I remember adding
a stable tag to this patch (to v2, changed my mind since v1) -- and it's
there in the lore link above.
Greg, just to make sure this wasn't due to a b4 bug; did you drop the
stable tag on purpose when applying?
The tag-order has been reshuffled by b4 too it seems (I know, some
people think that's ok) so maybe it fell out in the process.
Johan
next prev parent reply other threads:[~2020-10-19 7:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201018191807.4052726-1-sashal@kernel.org>
2020-10-18 19:17 ` [PATCH AUTOSEL 5.9 047/111] usb: dwc3: Add splitdisable quirk for Hisilicon Kirin Soc Sasha Levin
2020-10-18 19:17 ` [PATCH AUTOSEL 5.9 048/111] usb: gadget: function: printer: fix use-after-free in __lock_acquire Sasha Levin
2020-10-18 19:17 ` [PATCH AUTOSEL 5.9 054/111] USB: cdc-acm: handle broken union descriptors Sasha Levin
2020-10-19 7:02 ` Johan Hovold [this message]
2020-10-19 7:10 ` Johan Hovold
2020-10-19 12:44 ` Konstantin Ryabitsev
2020-10-19 7:13 ` Greg Kroah-Hartman
2020-10-18 19:17 ` [PATCH AUTOSEL 5.9 056/111] usb: dwc3: simple: add support for Hikey 970 Sasha Levin
2020-10-18 19:17 ` [PATCH AUTOSEL 5.9 070/111] usb: ohci: Default to per-port over-current protection Sasha Levin
2020-10-18 19:17 ` [PATCH AUTOSEL 5.9 102/111] usb: core: Solve race condition in anchor cleanup functions Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201019070218.GO26280@localhost \
--to=johan@kernel.org \
--cc=f1rmb.daniel@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).