* [PATCH v2] usb: serial: iuu_phoenix remove unneeded break
@ 2020-10-26 19:14 trix
2020-10-27 8:38 ` Johan Hovold
0 siblings, 1 reply; 2+ messages in thread
From: trix @ 2020-10-26 19:14 UTC (permalink / raw)
To: johan, gregkh; +Cc: linux-usb, linux-kernel, Tom Rix
From: Tom Rix <trix@redhat.com>
A break is not needed if it is preceded by a return.
Signed-off-by: Tom Rix <trix@redhat.com>
---
v2: split from original larger patch
---
drivers/usb/serial/iuu_phoenix.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/serial/iuu_phoenix.c b/drivers/usb/serial/iuu_phoenix.c
index b4ba79123d9d..f1201d4de297 100644
--- a/drivers/usb/serial/iuu_phoenix.c
+++ b/drivers/usb/serial/iuu_phoenix.c
@@ -850,7 +850,6 @@ static int iuu_uart_baud(struct usb_serial_port *port, u32 baud_base,
default:
kfree(dataout);
return IUU_INVALID_PARAMETER;
- break;
}
switch (parity & 0xF0) {
@@ -864,7 +863,6 @@ static int iuu_uart_baud(struct usb_serial_port *port, u32 baud_base,
default:
kfree(dataout);
return IUU_INVALID_PARAMETER;
- break;
}
status = bulk_immediate(port, dataout, DataCount);
--
2.18.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] usb: serial: iuu_phoenix remove unneeded break
2020-10-26 19:14 [PATCH v2] usb: serial: iuu_phoenix remove unneeded break trix
@ 2020-10-27 8:38 ` Johan Hovold
0 siblings, 0 replies; 2+ messages in thread
From: Johan Hovold @ 2020-10-27 8:38 UTC (permalink / raw)
To: trix; +Cc: johan, gregkh, linux-usb, linux-kernel
On Mon, Oct 26, 2020 at 12:14:50PM -0700, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> A break is not needed if it is preceded by a return.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> v2: split from original larger patch
Applied, thanks.
Johan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-27 8:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-26 19:14 [PATCH v2] usb: serial: iuu_phoenix remove unneeded break trix
2020-10-27 8:38 ` Johan Hovold
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).