Re: [PATCH v12 01/10] dt-bindings: usb: Maxim type-c controller device tree binding document

Rob Herring
2020-10-29T15:37:21Z

On Wed, 28 Oct 2020 23:31:29 -0700, Badhri Jagan Sridharan wrote:
> Add device tree binding document for Maxim 33359 Type-C chip driver
>
> Signed-off-by: Badhri Jagan Sridharan <badhri@google.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> ---
> Changes since v1:
> - Changing patch version to v6 to fix version number confusion.
>
> Changes since v6:
> - Migrated to yaml format.
>
> Changes since v7:
> - Rebase on usb-next
>
> Changes since v8:
> - Fix errors from make dt_binding_check as suggested by
> Rob Herring.
>
> Changes since v9:
> - additionalProperties: false as suggested by Rob Herring.
>
> Changes since v10:
> - Added the chip number to the binding as suggested by Rob Herring.
> - Renamed the filename as well.
>
> Changes since v11:
> Addressed comments from Rob Herring to rename from maxim,33359
> to maxim,max33359
> ---
> .../bindings/usb/maxim,max33359.yaml | 75 +++++++++++++++++++
> 1 file changed, 75 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/usb/maxim,max33359.yaml
>

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Error: Documentation/devicetree/bindings/usb/maxim,max33359.example.dts:39.53-54 syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [scripts/Makefile.lib:342: Documentation/devicetree/bindings/usb/maxim,max33359.example.dt.yaml] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1364: dt_binding_check] Error 2

See https://patchwork.ozlabs.org/patch/1389879

The base for the patch is generally the last rc1. Any dependencies
should be noted.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.