From: Tony Lindgren <tony@atomide.com>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Bin Liu <b-liu@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
od@zcrc.me, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org,
Maarten ter Huurne <maarten@treewalker.org>
Subject: Re: [RESEND PATCH 2/4] usb: musb: Fix NULL check on struct musb_request field
Date: Thu, 29 Oct 2020 16:58:53 +0200 [thread overview]
Message-ID: <20201029145853.GK5639@atomide.com> (raw)
In-Reply-To: <20201027164200.18602-3-paul@crapouillou.net>
* Paul Cercueil <paul@crapouillou.net> [201027 16:42]:
> The 'request' variable is a pointer to the 'request' field of the
> struct musb_request 'req' pointer. It only worked until now because
> the 'request' field is the first one in the musb_request structure, but
> as soon as that changes, the check will be invalid.
>
> Fix it preventively by doing the NULL-check on the 'req' pointer
> instead.
Acked-by: Tony Lindgren <tony@atomide.com>
next prev parent reply other threads:[~2020-10-29 14:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 16:41 [RESEND PATCH 0/4] MUSB and jz4740-musb fixes Paul Cercueil
2020-10-27 16:41 ` [RESEND PATCH 1/4] usb: musb: Fix runtime PM race in musb_queue_resume_work Paul Cercueil
2020-10-27 16:41 ` [RESEND PATCH 2/4] usb: musb: Fix NULL check on struct musb_request field Paul Cercueil
2020-10-29 14:58 ` Tony Lindgren [this message]
2020-10-27 16:41 ` [RESEND PATCH 3/4] usb: musb: dma: Remove unused variable Paul Cercueil
2020-10-27 16:42 ` [RESEND PATCH 4/4] musb: jz4740: Add missing CR to error strings Paul Cercueil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201029145853.GK5639@atomide.com \
--to=tony@atomide.com \
--cc=b-liu@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=maarten@treewalker.org \
--cc=od@zcrc.me \
--cc=paul@crapouillou.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).