From: Greg KH <gregkh@linuxfoundation.org>
To: Luo Jiaxing <luojiaxing@huawei.com>
Cc: akpm@linux-foundation.org, viro@zeniv.linux.org.uk,
andriy.shevchenko@linux.intel.com, linux-kernel@vger.kernel.org,
martin.petersen@oracle.com, john.garry@huawei.com,
himanshu.madhani@cavium.com, felipe.balbi@linux.intel.com,
uma.shankar@intel.com, anshuman.gupta@intel.com,
animesh.manna@intel.com, linux-usb@vger.kernel.org,
linux-scsi@vger.kernel.org, linuxarm@huawei.com
Subject: Re: [PATCH v3 0/5] Introduce a new helper marco DEFINE_SHOW_STORE_ATTRIBUTE at seq_file.c
Date: Tue, 3 Nov 2020 14:36:44 +0100 [thread overview]
Message-ID: <20201103133644.GA2067567@kroah.com> (raw)
In-Reply-To: <1604406584-53926-1-git-send-email-luojiaxing@huawei.com>
On Tue, Nov 03, 2020 at 08:29:39PM +0800, Luo Jiaxing wrote:
> We already own DEFINE_SHOW_ATTRIBUTE() helper macro for defining attribute
> for read-only file, but we found many of drivers also want a helper macro
> for read-write file too.
>
> So we add this macro to help decrease code duplication.
>
> ---
> v1->v2:
> 1.Rename DEFINE_STORE_ATTRIBUTE() to DEFINE_SHOW_STORE_ATTRIBUTE().
> v2->v3:
> 1.Fixed some spelling mistakes in commit.
> 2.Revised resumes are added for easy tracing.
You forgot to address Al Viro's review comments :(
next prev parent reply other threads:[~2020-11-03 13:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 12:29 [PATCH v3 0/5] Introduce a new helper marco DEFINE_SHOW_STORE_ATTRIBUTE at seq_file.c Luo Jiaxing
2020-11-03 12:29 ` [PATCH v3 1/5] seq_file: Introduce DEFINE_SHOW_STORE_ATTRIBUTE() helper macro Luo Jiaxing
2020-11-03 12:29 ` [PATCH v3 2/5] scsi: hisi_sas: Introduce DEFINE_SHOW_STORE_ATTRIBUTE for debugfs Luo Jiaxing
2020-11-03 12:29 ` [PATCH v3 3/5] scsi: qla2xxx: " Luo Jiaxing
2020-11-03 12:29 ` [PATCH v3 4/5] usb: dwc3: debugfs: Introduce DEFINE_SHOW_STORE_ATTRIBUTE Luo Jiaxing
2020-11-03 12:29 ` [PATCH v3 5/5] drm/i915/display: Introduce DEFINE_SHOW_STORE_ATTRIBUTE for debugfs Luo Jiaxing
2020-11-03 13:36 ` Greg KH [this message]
2020-11-03 13:45 ` [PATCH v3 0/5] Introduce a new helper marco DEFINE_SHOW_STORE_ATTRIBUTE at seq_file.c Alan Stern
2020-11-05 11:08 ` luojiaxing
2020-11-05 11:05 ` luojiaxing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201103133644.GA2067567@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=animesh.manna@intel.com \
--cc=anshuman.gupta@intel.com \
--cc=felipe.balbi@linux.intel.com \
--cc=himanshu.madhani@cavium.com \
--cc=john.garry@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=luojiaxing@huawei.com \
--cc=martin.petersen@oracle.com \
--cc=uma.shankar@intel.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).